Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1429063003: Use a register for the tail call address where appropriate. (Closed)

Created:
5 years, 1 month ago by jbramley
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a register for the tail call address where appropriate. BUG= Committed: https://crrev.com/c7012285343bfb6eee512e2a64d5d7ef98f542fc Cr-Commit-Position: refs/heads/master@{#31883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
Jarin, I think this was incorrectly ported during f5d42d04 (r31561), but it may have been ...
5 years, 1 month ago (2015-11-09 10:59:30 UTC) #2
Jarin
You are right, I was not careful enough. Thanks for fixing this! lgtm.
5 years, 1 month ago (2015-11-09 11:58:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429063003/1
5 years, 1 month ago (2015-11-09 12:34:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 14:04:30 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 14:04:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7012285343bfb6eee512e2a64d5d7ef98f542fc
Cr-Commit-Position: refs/heads/master@{#31883}

Powered by Google App Engine
This is Rietveld 408576698