Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1429003004: Parse text-emphasis shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse text-emphasis shorthand in CSSPropertyParser with CSSParserTokens Move text-emphasis shorthand property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. BUG=499780 Committed: https://crrev.com/a8b848fdaed57dfbe4505d3cc77ab75871151cf7 Cr-Commit-Position: refs/heads/master@{#358440}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -58 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 5 chunks +31 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 4 chunks +3 lines, -55 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-05 11:51:49 UTC) #3
rwlbuis
PTAL, but this one has to go in first: https://codereview.chromium.org/1405273005/
5 years, 1 month ago (2015-11-05 21:58:33 UTC) #4
Timothy Loh
On 2015/11/05 21:58:33, rwlbuis wrote: > PTAL, but this one has to go in first: ...
5 years, 1 month ago (2015-11-06 00:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429003004/20001
5 years, 1 month ago (2015-11-06 21:32:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 23:13:17 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 23:14:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8b848fdaed57dfbe4505d3cc77ab75871151cf7
Cr-Commit-Position: refs/heads/master@{#358440}

Powered by Google App Engine
This is Rietveld 408576698