Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1428983002: Fix closure compiler error. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam, yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, Jeremy Klein
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compiler error. Fixes compile error caused by https://codereview.chromium.org/1425033006. Although AudioPlayerElement's new property can be resolved by reading element's script directly, I fixes this in old style (using extern) for now. BUG=none TBR=yawano@chromium.org Committed: https://crrev.com/095f2d2efe7c765e0e35eb3077471e753a01c7cf Cr-Commit-Position: refs/heads/master@{#357120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/file_manager/externs/files_elements.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428983002/1
5 years, 1 month ago (2015-10-30 16:21:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 16:34:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/095f2d2efe7c765e0e35eb3077471e753a01c7cf Cr-Commit-Position: refs/heads/master@{#357120}
5 years, 1 month ago (2015-10-30 16:35:24 UTC) #6
Dan Beam
we should be using the scripts directly instead of using externs. that's why jlklein@ created ...
5 years, 1 month ago (2015-10-30 20:56:43 UTC) #8
fukino
5 years, 1 month ago (2015-10-30 23:24:28 UTC) #9
Message was sent while issue was closed.
On 2015/10/30 20:56:43, Dan Beam wrote:
> we should be using the scripts directly instead of using externs.  that's why
> jlklein@ created --polymer_pass (which we're already sending to the closure
> compiler)

Yes, as described in the CL description, this is an old stye which was needed
before --polymer_pass.
I'll update them next week. Thanks!

Powered by Google App Engine
This is Rietveld 408576698