Utilize ProfileInfoCache to support data type counts in profile deletion flow

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 958 matching lines @@
     /**
      * Gets the custom icon. This icon is normally hidden, but can be shown
      * using the chrome.screenlockPrivate API.
      * @type {!HTMLDivElement}
      */
     get customIconElement() {
       return this.querySelector('.custom-icon-container');
     },
 
     /**
+     * Get the elements used for statistics display.
+     * @type {Object.<string, !HTMLDivElement>}
+     */
+    get statsMapElements() {
+      return {
+          'browsing_history':
+              this.querySelector('.action-box-remove-user-warning-history'),
+          'passwords':
+              this.querySelector('.action-box-remove-user-warning-passwords'),
+          'bookmarks':
+              this.querySelector('.action-box-remove-user-warning-bookmarks'),
+          'settings':
+              this.querySelector('.action-box-remove-user-warning-settings')
+      }
+    },
+
+    /**
      * Updates the user pod element.
      */
     update: function() {
       this.imageElement.src = 'chrome://userimage/' + this.user.username +
           '?id=' + UserPod.userImageSalt_[this.user.username];
 
       this.nameElement.textContent = this.user_.displayName;
       this.reauthNameHintElement.textContent = this.user_.displayName;
       this.classList.toggle('signed-in', this.user_.signedIn);
 
@@ skipping 407 matching lines @@
 
       // Move up the menu if it overlaps shelf.
       var maxHeight = cr.ui.LoginUITools.getMaxHeightBeforeShelfOverlapping(
           this.actionBoxMenu, true);
       var actualHeight = parseInt(
           window.getComputedStyle(this.actionBoxMenu).height);
       if (maxHeight < actualHeight) {
         this.actionBoxMenu.classList.add('menu-moved-up');
         this.actionBoxAreaElement.classList.add('menu-moved-up');
       }
-      chrome.send('logRemoveUserWarningShown');
     },
 
     /**
      * Shows remove user warning. Used for legacy supervised users on CrOS, and
      * for all users on desktop.
      */
     showRemoveWarning_: function() {
       this.actionBoxMenuRemoveElement.hidden = true;
       this.actionBoxRemoveUserWarningElement.hidden = false;
       this.actionBoxRemoveUserWarningButtonElement.focus();
 
       // Show extra statistics information for desktop users
       var message;
-      if (this.user.isDesktopUser) {
-        this.classList.remove('has-errors');
-        var isSyncedUser = this.user.emailAddress !== "";
-        if (!this.user.isProfileLoaded) {
-          message = loadTimeData.getString(
-              isSyncedUser ? 'removeUserWarningTextSyncNoStats' :
-              'removeUserWarningTextNonSyncNoStats');
-          this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
-                                                    message);
-        } else {
-          message = loadTimeData.getString(
-              isSyncedUser ? 'removeUserWarningTextSyncCalculating' :
-              'removeUserWarningTextNonSyncCalculating');
-          substitute = loadTimeData.getString(
-              'removeUserWarningTextCalculating');
-          this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
-                                                    message, substitute);
-        }
-
+      if (this.user.isLegacySupervisedUser) {
+        this.moveActionMenuUpIfNeeded_();
+      } else {
+        this.RemoveWarningDialogSetMessage_(true, false);
         // set a global handler for the callback
         window.updateRemoveWarningDialog =
             this.updateRemoveWarningDialog_.bind(this);
         chrome.send('removeUserWarningLoadStats', [this.user.profilePath]);
       }
-
-      this.moveActionMenuUpIfNeeded_();
+      chrome.send('logRemoveUserWarningShown');
     },
 
     /**
      * Refresh the statistics in the remove user warning dialog.
      * @param {string} profilePath The filepath of the URL (must be verified).
      * @param {Object} profileStats Statistics associated with profileURL.
      */
     updateRemoveWarningDialog_: function(profilePath, profileStats) {
       if (profilePath !== this.user.profilePath)
         return;
-      // Converting profileStats into id attribute by an object.
-      var stats_id_map = {
-        'BrowsingHistory': 'action-box-remove-user-warning-history',
-        'Passwords': 'action-box-remove-user-warning-passwords',
-        'Bookmarks': 'action-box-remove-user-warning-bookmarks',
-        'Settings': 'action-box-remove-user-warning-settings',
-      }
-      // Load individual statistics
+
+      var stats_elements = this.statsMapElements;
+      // Update individual statistics
       var num_stats_loaded = 0;
-      var total_count = 0;
       var failed = false;
       for (var key in profileStats) {
-        if (stats_id_map.hasOwnProperty(key)) {
+        if (stats_elements.hasOwnProperty(key)) {
           if (profileStats[key].success) {
-            var count = profileStats[key].count;
-            this.querySelector("." + stats_id_map[key]).textContent = count;
-            total_count += count;
-          } else {
+            this.user.statistics[key] = profileStats[key].count;
+          } else if (!this.user.statistics.hasOwnProperty(key)) {
             failed = true;
-            this.querySelector("." + stats_id_map[key]).textContent = '';
+            stats_elements[key].textContent = '';
           }
           num_stats_loaded++;
         }
       }
 
-      // this.classList is used for selecting the appropriate dialog.
-      this.classList.toggle('has-errors', failed);
-      if (total_count > 0) {
-        this.classList.remove('has-no-stats');
+      this.RemoveWarningDialogSetMessage_(
+          false, failed && num_stats_loaded === this.statsMapElements.count);
+    },
+
+    /**
+     * Set the new message in the dialog.
+     * @param {boolean} Whether this statistics are not available due to errors.
+     * Should be true only if there is an error and the corresponding statistic
+     * is also unavailable in ProfileInfoCache.
+     */
+    RemoveWarningDialogSetMessage_: function(isInitial, isError) {
+      var stats_elements = this.statsMapElements;
+      var num_stats_loaded = 0;
+      var total_count = 0;
+      for (var key in stats_elements) {
+        if (this.user.statistics.hasOwnProperty(key)) {
+          var count = this.user.statistics[key];
+          stats_elements[key].textContent = count;
+          total_count += count;
+          num_stats_loaded++;
+        }
       }
 
+      // this.classList is used for selecting the appropriate dialog.
+      if (total_count)
+        this.classList.remove('has-no-stats');
+
+      var is_synced_user = this.user.emailAddress !== "";
       // Write total number if all statistics are loaded.
-      if (num_stats_loaded === Object.keys(stats_id_map).length) {
-        if (total_count === 0) {
+      if (num_stats_loaded === Object.keys(stats_elements).length || isError) {
+        if (!total_count) {
           this.classList.add('has-no-stats');
-          var isSyncedUser = this.user.emailAddress !== "";
           var message = loadTimeData.getString(
-              isSyncedUser ? 'removeUserWarningTextSyncNoStats' :
-              'removeUserWarningTextNonSyncNoStats');
+              is_synced_user ? 'removeUserWarningTextSyncNoStats' :
+                               'removeUserWarningTextNonSyncNoStats');
           this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
                                                     message);
         } else {
           window.updateRemoveWarningDialogSetMessage =
               this.updateRemoveWarningDialogSetMessage_.bind(this);
           chrome.send('getRemoveWarningDialogMessage',[{
               profilePath: this.user.profilePath,
-              isSyncedUser: this.user.emailAddress !== "",
-              hasErrors: failed,
+              isSyncedUser: is_synced_user,
+              hasErrors: num_stats_loaded < Object.keys(stats_elements).length,
               totalCount: total_count
           }]);
         }
+      } else if (isInitial) {
+        if (!this.user.isProfileLoaded) {
+          message = loadTimeData.getString(
+              is_synced_user ? 'removeUserWarningTextSyncNoStats' :
+                               'removeUserWarningTextNonSyncNoStats');
+          this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
+                                                    message);
+        } else {
+          message = loadTimeData.getString(
+              is_synced_user ? 'removeUserWarningTextSyncCalculating' :
+                               'removeUserWarningTextNonSyncCalculating');
+          substitute = loadTimeData.getString(
+              'removeUserWarningTextCalculating');
+          this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
+                                                    message, substitute);
+        }
       }
-
-      this.moveActionMenuUpIfNeeded_();
     },
 
     /**
      * Refresh the message in the remove user warning dialog.
      * @param {string} profilePath The filepath of the URL (must be verified).
      * @param {string} message The message to be written.
      * @param {number|string=} count The number or string to replace $1 in
      * |message|. Can be omitted if $1 is not present in |message|.
      */
     updateRemoveWarningDialogSetMessage_: function(profilePath, message,
                                                    count) {
       if (profilePath !== this.user.profilePath)
         return;
       // Add localized messages where $1 will be replaced with
       // <span class="total-count"></span>.
       var element = this.querySelector('.action-box-remove-user-warning-text');
-      while (element.firstChild)
-        element.removeChild(element.firstChild);
+      element.textContent = '';
 
       messageParts = message.split('$1');
       var numParts = messageParts.length;
       for (var j = 0; j < numParts; j++) {
         element.appendChild(document.createTextNode(messageParts[j]));
         if (j < numParts - 1) {
           var elementToAdd = document.createElement('span');
           elementToAdd.classList.add('total-count');
           elementToAdd.textContent = count;
           element.appendChild(elementToAdd);
         }
       }
+      this.moveActionMenuUpIfNeeded_();
     },
 
     /**
      * Handles a click event on remove user confirmation button.
      * @param {Event} e Click event.
      */
     handleRemoveUserConfirmationClick_: function(e) {
       if (this.isActionBoxMenuActive) {
         this.isActionBoxMenuActive = false;
         this.removeUser(this.user);
@@ skipping 519 matching lines @@
 
       var isLockedUser = this.user.needsSignin;
       var isLegacySupervisedUser = this.user.legacySupervisedUser;
       var isChildUser = this.user.childUser;
       var isSyncedUser = this.user.emailAddress !== "";
       var isProfileLoaded = this.user.isProfileLoaded;
       this.classList.toggle('locked', isLockedUser);
       this.classList.toggle('legacy-supervised', isLegacySupervisedUser);
       this.classList.toggle('child', isChildUser);
       this.classList.toggle('synced', isSyncedUser);
-      this.classList.toggle('has-no-stats', !isProfileLoaded);
+      this.classList.toggle('has-no-stats',
+          !isProfileLoaded && !this.user.statistics.length);
 
       if (this.isAuthTypeUserClick)
         this.passwordLabelElement.textContent = this.authValue;
 
       this.passwordElement.setAttribute('aria-label', loadTimeData.getStringF(
         'passwordFieldAccessibleName', this.user_.emailAddress));
 
       UserPod.prototype.updateActionBoxArea.call(this);
     },
 
@@ skipping 1202 matching lines @@
        if (pod && pod.multiProfilesPolicyApplied) {
          pod.userTypeBubbleElement.classList.remove('bubble-shown');
        }
      }
   };
 
   return {
     PodRow: PodRow
   };
 });