Utilize ProfileInfoCache to support data type counts in profile deletion flow

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 20 matching lines @@
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/password_manager/password_manager_setting_migrator_service.h"
 #include "chrome/browser/password_manager/password_manager_setting_migrator_service_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/bookmark_model_loaded_observer.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_destroyer.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_metrics.h"
+#include "chrome/browser/profiles/profile_statistics.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/account_fetcher_service_factory.h"
 #include "chrome/browser/signin/account_reconcilor_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/cross_device_promo.h"
 #include "chrome/browser/signin/cross_device_promo_factory.h"
 #include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 993 matching lines @@
 
   DoFinalInitForServices(profile, go_off_the_record);
   AddProfileToCache(profile);
   DoFinalInitLogging(profile);
 
   ProfileMetrics::LogNumberOfProfiles(this);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PROFILE_ADDED,
       content::Source<Profile>(profile),
       content::NotificationService::NoDetails());
+
+  // Record statistics to ProfileInfoCache if not a normal shutdown.
+  if (!profile->IsGuestSession() && !profile->IsSystemProfile() &&
+      !profile->IsNewProfile() && !go_off_the_record &&
+      profile->GetLastSessionExitType() != Profile::EXIT_NORMAL)
+    profiles::StoreProfileStatisticsToCache(profile);

[lwchkg, 2015/11/08 15:45:58]

This is causing Chromium to crash if the exit type is END_SESSION (but not
CRASHED). Any ideas why this is crashing?

P.S. The bad thing here is I don't get a stack trace even if the debug symbols
are on. Does Chromium crash without a stack trace in some specific situation?

[lwchkg, 2015/11/09 21:00:09]

Found the reason of crash: attempting to access the root nodes in BookmarkModel
before the nodes are loaded, so BookmarkNode::is_url() crashed. Is it possible
to put the code somewhere else where initialization is guaranteed to be
finished?

[Mike Lerman, 2015/11/10 15:45:44]

Some of the services you're looking at may be initializing on their own threads.
The ProfileStatistics should be responsible for delaying capture of each
service's counts until that service is initialized.

[lwchkg, 2015/11/10 18:11:07]

Thanks. I've checked the services, and it looks like only BookmarkModel is
affected. The bookmarks are loaded async if we are the earliest consumer of the
bookmarks.

 }
 
 void ProfileManager::DoFinalInitForServices(Profile* profile,
                                             bool go_off_the_record) {
   TRACE_EVENT0("browser", "ProfileManager::DoFinalInitForServices");
   TRACK_SCOPED_REGION("Startup", "ProfileManager::DoFinalInitForServices");
 
 #if defined(ENABLE_EXTENSIONS)
   ProfileInfoCache& cache = GetProfileInfoCache();
 
@@ skipping 378 matching lines @@
 
 void ProfileManager::BrowserListObserver::OnBrowserRemoved(
     Browser* browser) {
   Profile* profile = browser->profile();
   for (chrome::BrowserIterator it; !it.done(); it.Next()) {
     if (it->profile()->GetOriginalProfile() == profile->GetOriginalProfile())
       // Not the last window for this profile.
       return;
   }
 
+  // Store statistics into ProfileInfoCache.
+  profiles::StoreProfileStatisticsToCache(profile);
+
   // If the last browser of a profile that is scheduled for deletion is closed
   // do that now.
   base::FilePath path = profile->GetPath();
   if (profile->GetPrefs()->GetBoolean(prefs::kForceEphemeralProfiles) &&
       !IsProfileMarkedForDeletion(path)) {
     g_browser_process->profile_manager()->ScheduleProfileForDeletion(
         path, ProfileManager::CreateCallback());
   }
 }
 
@@ skipping 39 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID) && !defined(OS_IOS)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }