Utilize ProfileInfoCache to support data type counts in profile deletion flow

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 20 matching lines @@
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/password_manager/password_manager_setting_migrator_service_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/bookmark_model_loaded_observer.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_destroyer.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_metrics.h"
+#include "chrome/browser/profiles/profile_statistics.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/account_fetcher_service_factory.h"
 #include "chrome/browser/signin/account_reconcilor_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/cross_device_promo.h"
 #include "chrome/browser/signin/cross_device_promo_factory.h"
 #include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 997 matching lines @@
 
   DoFinalInitForServices(profile, go_off_the_record);
   AddProfileToCache(profile);
   DoFinalInitLogging(profile);
 
   ProfileMetrics::LogNumberOfProfiles(this);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PROFILE_ADDED,
       content::Source<Profile>(profile),
       content::NotificationService::NoDetails());
+
+  // Record statistics to ProfileInfoCache if not a normal shutdown.

[Mike Lerman, 2015/11/26 15:06:25]

rephrase to
Record statistics to ProfileInfoCache if the last shutdown wasn't clean.

[lwchkg, 2015/12/02 15:33:34]

Yeah we need to make this comment clearer.

I've rather for "Record statistics to ProfileInfoCache if the last shutdown was
a result of a system shutdown or a crash."

Anyway, the words "wasn't clean" contradicts the code/comment in
browser_process_impl.cc (see the link below), so I've made the above suggestion.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/bro...

+  if (!profile->IsGuestSession() && !profile->IsSystemProfile() &&
+      !profile->IsNewProfile() && !go_off_the_record &&
+      profile->GetLastSessionExitType() != Profile::EXIT_NORMAL)

[Mike Lerman, 2015/11/26 15:06:25]

nit: use braces around the statement

[lwchkg, 2015/12/02 15:33:34]

Yeah it looks better with the braces.

Just something out-of-topic: do you know about any recent changes to Google C++
style about conditionals? I remember that single-line conditionals like
    if (x == kFoo) return new Foo();
were forbidden, but the read today says that it's allowed.

https://google.github.io/styleguide/cppguide.html#Conditionals

[Mike Lerman, 2015/12/07 16:21:20]

I'm not aware of a change, but that doesn't mean one didn't happen.

The braces are required if either the statement or the condition are multi-line.

[lwchkg, 2015/12/09 03:39:41]

I see. I can't read this message clearly with the current version of the c++
style guide. Maybe the guide needs some rephrasing.

+    profiles::StoreProfileStatisticsToCache(profile);
 }
 
 void ProfileManager::DoFinalInitForServices(Profile* profile,
                                             bool go_off_the_record) {
   TRACE_EVENT0("browser", "ProfileManager::DoFinalInitForServices");
   TRACK_SCOPED_REGION("Startup", "ProfileManager::DoFinalInitForServices");
 
 #if defined(ENABLE_EXTENSIONS)
   ProfileInfoCache& cache = GetProfileInfoCache();
 
@@ skipping 386 matching lines @@
 
 void ProfileManager::BrowserListObserver::OnBrowserRemoved(
     Browser* browser) {
   Profile* profile = browser->profile();
   for (chrome::BrowserIterator it; !it.done(); it.Next()) {
     if (it->profile()->GetOriginalProfile() == profile->GetOriginalProfile())
       // Not the last window for this profile.
       return;
   }
 
+  // Store statistics into ProfileInfoCache.
+  profiles::StoreProfileStatisticsToCache(profile);
+
   // If the last browser of a profile that is scheduled for deletion is closed
   // do that now.
   base::FilePath path = profile->GetPath();
   if (profile->GetPrefs()->GetBoolean(prefs::kForceEphemeralProfiles) &&
       !IsProfileMarkedForDeletion(path)) {
     g_browser_process->profile_manager()->ScheduleProfileForDeletion(
         path, ProfileManager::CreateCallback());
   }
 }
 
@@ skipping 39 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID) && !defined(OS_IOS)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }