Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1428963002: ash: Remove --internal-display-color-profile-file (Closed)

Created:
5 years, 1 month ago by robert.bradford
Modified:
5 years, 1 month ago
Reviewers:
Greg Levin, *oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove --internal-display-color-profile-file This was useful for debugging and early integration efforts in ChromeOS and is no longer required. BUG=549558 TEST=On amd64-generic_freon observe that loading from named .icc file functions correctly. Committed: https://crrev.com/dac70afef0bbd3661067adcb7746a56f5baf22b2 Cr-Commit-Position: refs/heads/master@{#357110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M ash/display/display_color_manager_chromeos.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
robert.bradford
oshima@ please take a look when you can. glevin@ FYI/non-OWNER review.
5 years, 1 month ago (2015-10-30 14:14:05 UTC) #3
oshima
lgtm thank you for cleaning this up!
5 years, 1 month ago (2015-10-30 14:44:06 UTC) #4
oshima
lgtm thank you for cleaning this up!
5 years, 1 month ago (2015-10-30 14:44:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428963002/1
5 years, 1 month ago (2015-10-30 15:16:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 15:42:22 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 15:43:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dac70afef0bbd3661067adcb7746a56f5baf22b2
Cr-Commit-Position: refs/heads/master@{#357110}

Powered by Google App Engine
This is Rietveld 408576698