Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1428953002: Simplify dispatch in FullCodeGenerator::VisitCall a bit. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
ulan, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify dispatch in FullCodeGenerator::VisitCall a bit. This makes FullCodeGenerator::VisitCall be independent of the target architecture. Only the EmitPossiblyEvalCall case was dependent and is hoisted into an emitter method. R=rossberg@chromium.org Committed: https://crrev.com/0b293d877ccc7155b54c485b3566514214110d47 Cr-Commit-Position: refs/heads/master@{#31693}

Patch Set 1 #

Patch Set 2 : Add MacroAssembler::PushRoot for ARM64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -583 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +28 lines, -74 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +29 lines, -76 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +26 lines, -71 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +28 lines, -73 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +28 lines, -73 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +28 lines, -74 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +26 lines, -71 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +26 lines, -71 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Follow-up to one of my previous CLs as promised.
5 years, 1 month ago (2015-10-30 13:18:18 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-10-30 14:00:25 UTC) #2
ulan
arm64 part lgtm
5 years, 1 month ago (2015-10-30 14:31:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428953002/20001
5 years, 1 month ago (2015-10-30 14:34:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 14:42:09 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:42:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b293d877ccc7155b54c485b3566514214110d47
Cr-Commit-Position: refs/heads/master@{#31693}

Powered by Google App Engine
This is Rietveld 408576698