Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1428943004: [turbofan] Remove redundant code. (Closed)

Created:
5 years, 1 month ago by Mircea Trofin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove redundant code. When I centralized the treatment of memory operands, I forgot to delete the old code. There is a semantic difference between the old and new code. The old code was handling either memory operands, or ranges that had a spilled predecessor. The new code handles just memory operands. It may happen that (using LinearScan) an active range is spilled when trying to allocate another range (see SplitAndSpillIntersecting). That may make it a candidate for the old version of the code, however, since we would have spilled up to a register use, the old code wouldn't have had taken effect. Perf data shows this nuance doesn't make a difference in perf. BUG= Committed: https://crrev.com/c03d7a7f03657a452f71277d84e435ed73566327 Cr-Commit-Position: refs/heads/master@{#31729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mircea Trofin
5 years, 1 month ago (2015-11-03 01:40:51 UTC) #3
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-03 05:32:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428943004/1
5 years, 1 month ago (2015-11-03 05:32:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 05:33:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c03d7a7f03657a452f71277d84e435ed73566327 Cr-Commit-Position: refs/heads/master@{#31729}
5 years, 1 month ago (2015-11-03 05:34:20 UTC) #8
Benedikt Meurer
5 years, 1 month ago (2015-11-03 07:41:54 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1416293004/ by bmeurer@chromium.org.

The reason for reverting is: This CL reintroduces all kinds of funny moves for
Merges of deferred code, which makes jump threading ineffective..

Powered by Google App Engine
This is Rietveld 408576698