Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1428923003: Don't do clean shutdown on Process.exit() (Closed)

Created:
5 years, 1 month ago by zra
Modified:
5 years, 1 month ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Exit isolate before exiting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -28 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/bin/main.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/process.cc View 1 2 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
CC johnmccutchan for removal of LEGACY_DEBUG_PROTOCOL_ENABLED
5 years, 1 month ago (2015-10-30 19:38:55 UTC) #2
zra
On 2015/10/30 19:38:55, zra wrote: > CC johnmccutchan for removal of LEGACY_DEBUG_PROTOCOL_ENABLED ping
5 years, 1 month ago (2015-11-03 18:36:20 UTC) #3
Cutch
lgtm
5 years, 1 month ago (2015-11-03 18:57:43 UTC) #5
zra
5 years, 1 month ago (2015-11-03 22:10:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c5044b671a5c98c425bf3dc48e23b922827e02c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698