Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1428923002: [turbofan] Specialize JSCallFunction based on CallIC feedback. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Specialize JSCallFunction based on CallIC feedback. If the CallIC collected a known target function for a callsite, add a runtime check to ensure that the feedback remains the same and specialize the JSCallFunction node to the known target function so that inlining and typed lowering can pick up the feedback. R=mstarzinger@chromium.org BUG=v8:4470, v8:4493 LOG=n Committed: https://crrev.com/961fef2dd2852db5165de3dbdbd13162792448fe Cr-Commit-Position: refs/heads/master@{#31689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-30 10:57:08 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, consuming feedback from CallIC. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-10-30 11:34:30 UTC) #2
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-10-30 12:40:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428923002/1
5 years, 1 month ago (2015-10-30 12:42:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428923002/1
5 years, 1 month ago (2015-10-30 12:55:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 12:57:27 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 12:57:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/961fef2dd2852db5165de3dbdbd13162792448fe
Cr-Commit-Position: refs/heads/master@{#31689}

Powered by Google App Engine
This is Rietveld 408576698