Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1428893003: Fix profiling on ARM64. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix profiling on ARM64. Linux/Android broken in 91bc8005fe28a4d613c3c9d26f03fd6ae08b83aa. iOS was unimplemented. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6d3bb00887537bf21e262344e7a36b3e3b0b1ff5

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M runtime/vm/signal_handler_android.cc View 1 chunk +1 line, -1 line 2 comments Download
M runtime/vm/signal_handler_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/signal_handler_macos.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
I had only updated this for ARM32...
5 years, 1 month ago (2015-10-30 00:45:23 UTC) #2
Cutch
LGTM with a suggestion https://codereview.chromium.org/1428893003/diff/1/runtime/vm/signal_handler_android.cc File runtime/vm/signal_handler_android.cc (right): https://codereview.chromium.org/1428893003/diff/1/runtime/vm/signal_handler_android.cc#newcode69 runtime/vm/signal_handler_android.cc:69: sp = static_cast<uintptr_t>(mcontext.regs[19]); Could we ...
5 years, 1 month ago (2015-10-30 02:29:57 UTC) #3
rmacnak
https://codereview.chromium.org/1428893003/diff/1/runtime/vm/signal_handler_android.cc File runtime/vm/signal_handler_android.cc (right): https://codereview.chromium.org/1428893003/diff/1/runtime/vm/signal_handler_android.cc#newcode69 runtime/vm/signal_handler_android.cc:69: sp = static_cast<uintptr_t>(mcontext.regs[19]); On 2015/10/30 02:29:57, Cutch wrote: > ...
5 years, 1 month ago (2015-10-30 16:17:41 UTC) #4
rmacnak
5 years, 1 month ago (2015-10-30 16:26:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6d3bb00887537bf21e262344e7a36b3e3b0b1ff5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698