Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1428853003: Disable VideoCaptureDeviceTest.ReAllocateCamera test. (Closed)

Created:
5 years, 1 month ago by DaleCurtis
Modified:
5 years, 1 month ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable VideoCaptureDeviceTest.ReAllocateCamera test. Fails consistently on my Linux workstation and also seems to have trouble on a variety of bots that actually have camera hardware, so disable everywhere. The primary cause seems to be that this will flake other tests when run in parallel. BUG=417824 TEST=all media_unittests pass when a camera is attached. Committed: https://crrev.com/899b90ef820f5fc973357d129e30431604e3a1ab Cr-Commit-Position: refs/heads/master@{#357147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
5 years, 1 month ago (2015-10-29 22:38:14 UTC) #2
phoglund_chromium
lgtm
5 years, 1 month ago (2015-10-30 09:55:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428853003/1
5 years, 1 month ago (2015-10-30 17:51:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:41:47 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:43:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/899b90ef820f5fc973357d129e30431604e3a1ab
Cr-Commit-Position: refs/heads/master@{#357147}

Powered by Google App Engine
This is Rietveld 408576698