extensions/browser/value_store/leveldb_value_store.h - Issue 1428843002: LeveldbValueStore: Deleting db when open fails due to corruption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/leveldb_value_store.h

Issue 1428843002: LeveldbValueStore: Deleting db when open fails due to corruption. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: EnsureDbIsOpen calling Restore when corrupted, also Recover -> Restore Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/value_store/leveldb_value_store.h

diff --git a/extensions/browser/value_store/leveldb_value_store.h b/extensions/browser/value_store/leveldb_value_store.h

index e763714280dcce9020ce561a89d90d7759919b29..d48628327f8b09e0d8d4abf3c536efe5a117ab92 100644

--- a/extensions/browser/value_store/leveldb_value_store.h

+++ b/extensions/browser/value_store/leveldb_value_store.h

@@ -92,7 +92,7 @@ class LeveldbValueStore : public ValueStore,

// Removes the on-disk database at |db_path_|. Any file system locks should

// be released before calling this method.

- void DeleteDbFile();

+ bool DeleteDbFile();

// Returns whether the database is empty.

bool IsEmpty();

@@ -103,6 +103,7 @@ class LeveldbValueStore : public ValueStore,

// leveldb backend.

scoped_ptr<leveldb::DB> db_;

base::HistogramBase* open_histogram_;

+ base::HistogramBase* restore_histogram_;

DISALLOW_COPY_AND_ASSIGN(LeveldbValueStore);

};

« no previous file with comments | « no previous file | extensions/browser/value_store/leveldb_value_store.cc » ('j') | extensions/browser/value_store/leveldb_value_store.cc » ('J')