MD Downloads: track downloads in C++, dispatch discrete JS updates

chrome/browser/download/download_query.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_query.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 51 matching lines @@
       return false;
     }
     out->push_back(element);
   }
   return true;
 }
 
 // The next several functions are helpers for making Callbacks that access
 // DownloadItem fields.
 
-static bool MatchesQuery(
-    const std::vector<base::string16>& query_terms,
-    const DownloadItem& item) {
-  DCHECK(!query_terms.empty());
-  base::string16 url_raw(base::UTF8ToUTF16(item.GetOriginalUrl().spec()));
-  base::string16 url_formatted = url_raw;
-  if (item.GetBrowserContext()) {
-    Profile* profile = Profile::FromBrowserContext(item.GetBrowserContext());
-    url_formatted = url_formatter::FormatUrl(
-        item.GetOriginalUrl(),
-        profile->GetPrefs()->GetString(prefs::kAcceptLanguages));
-  }
-  base::string16 path(item.GetTargetFilePath().LossyDisplayName());
-
-  for (std::vector<base::string16>::const_iterator it = query_terms.begin();
-       it != query_terms.end(); ++it) {
-    base::string16 term = base::i18n::ToLower(*it);
-    if (!base::i18n::StringSearchIgnoringCaseAndAccents(
-            term, url_raw, NULL, NULL) &&
-        !base::i18n::StringSearchIgnoringCaseAndAccents(
-            term, url_formatted, NULL, NULL) &&
-        !base::i18n::StringSearchIgnoringCaseAndAccents(
-            term, path, NULL, NULL)) {
-      return false;
-    }
-  }
-  return true;
-}
-
 static int64 GetStartTimeMsEpoch(const DownloadItem& item) {
   return (item.GetStartTime() - base::Time::UnixEpoch()).InMilliseconds();
 }
 
 static int64 GetEndTimeMsEpoch(const DownloadItem& item) {
   return (item.GetEndTime() - base::Time::UnixEpoch()).InMilliseconds();
 }
 
 std::string TimeToISO8601(const base::Time& t) {
   base::Time::Exploded exploded;
@@ skipping 119 matching lines @@
   ValueType left_value = accessor.Run(left);
   ValueType right_value = accessor.Run(right);
   if (left_value > right_value) return GT;
   if (left_value < right_value) return LT;
   DCHECK_EQ(left_value, right_value);
   return EQ;
 }
 
 }  // anonymous namespace
 
+// static
+bool DownloadQuery::MatchesQuery(const std::vector<base::string16>& query_terms,
+                                 const DownloadItem& item) {
+  if (query_terms.empty())
+    return true;

[Dan Beam, 2015/11/25 20:23:23]

asanka@: note ^

[asanka, 2015/11/25 20:49:06]

Noted.

+
+  base::string16 url_raw(base::UTF8ToUTF16(item.GetOriginalUrl().spec()));
+  base::string16 url_formatted = url_raw;
+  if (item.GetBrowserContext()) {
+    Profile* profile = Profile::FromBrowserContext(item.GetBrowserContext());
+    url_formatted = url_formatter::FormatUrl(
+        item.GetOriginalUrl(),
+        profile->GetPrefs()->GetString(prefs::kAcceptLanguages));
+  }
+  base::string16 path(item.GetTargetFilePath().LossyDisplayName());
+
+  for (std::vector<base::string16>::const_iterator it = query_terms.begin();
+       it != query_terms.end(); ++it) {
+    base::string16 term = base::i18n::ToLower(*it);
+    if (!base::i18n::StringSearchIgnoringCaseAndAccents(
+            term, url_raw, NULL, NULL) &&
+        !base::i18n::StringSearchIgnoringCaseAndAccents(
+            term, url_formatted, NULL, NULL) &&
+        !base::i18n::StringSearchIgnoringCaseAndAccents(
+            term, path, NULL, NULL)) {
+      return false;
+    }
+  }
+  return true;
+}
+
 DownloadQuery::DownloadQuery() : limit_(kuint32max), skip_(0U) {}
 DownloadQuery::~DownloadQuery() {}
 
 // AddFilter() pushes a new FilterCallback to filters_. Most FilterCallbacks are
 // Callbacks to FieldMatches<>(). Search() iterates over given DownloadItems,
 // discarding items for which any filter returns false. A DownloadQuery may have
 // zero or more FilterCallbacks.
 
 bool DownloadQuery::AddFilter(const DownloadQuery::FilterCallback& value) {
   if (value.is_null()) return false;
@@ skipping 189 matching lines @@
         results->begin() + std::min(limit_ + skip_, results->size()),
         results->end(),
         DownloadComparator(sorters_));
   }
 
   results->erase(results->begin(), results->begin() + skip_);
 
   if (results->size() > limit_)
     results->resize(limit_);
 }