MD Downloads: track downloads in C++, dispatch discrete JS updates

chrome/browser/resources/md_downloads/action_service.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   /**
    * @param {string} chromeSendName
    * @return {function(string):void} A chrome.send() callback with curried name.
    */
   function chromeSendWithId(chromeSendName) {
@@ skipping 27 matching lines @@
     },
 
     /** @param {string} id ID of the download that the user started dragging. */
     drag: chromeSendWithId('drag'),
 
     /**
      * @return {boolean} Whether the user is currently searching for downloads
      *     (i.e. has a non-empty search term).
      */
     isSearching: function() {
-      return this.searchText_.length > 0;
+      return (this.searchText_ || '').length > 0;

[asanka, 2015/11/24 22:08:22]

!!this.searchText_

or do you folks dislike that expression?

[Dan Beam, 2015/11/25 04:06:36]

Done.

     },
 
     /** Opens the current local destination for downloads. */
     openDownloadsFolder: chrome.send.bind(chrome, 'openDownloadsFolder'),
 
     /**
      * @param {string} id ID of the download to run locally on the user's box.
      */
     openFile: chromeSendWithId('openFile'),
 
@@ skipping 12 matching lines @@
      */
     saveDangerous: chromeSendWithId('saveDangerous'),
 
     /** @param {string} searchText What to search for. */
     search: function(searchText) {
       if (this.searchText_ == searchText)
         return;
 
       this.searchText_ = searchText;
 
+      /**
+       * @param {string} s
+       * @return {string} |s| without whitespace at the ends (trimmed).
+       */
+      function trim(s) { return s.trim(); }
+
       // Split quoted terms (e.g., 'The "lazy" dog' => ['The', 'lazy', 'dog']).
-      function trim(s) { return s.trim(); }
-      chrome.send('getDownloads', searchText.split(/"([^"]*)"/).map(trim));
+      var terms = searchText ? searchText.split(/"([^"]*)"/).map(trim) : [];

[dpapad, 2015/11/24 18:42:33]

Is it worth adding tests for the regular expression? This could be a unit_test
(no DOM), similar to
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res....

[Dan Beam, 2015/11/25 04:06:36]

Done.

+
+      chrome.send('getDownloads', terms);
     },
 
     /**
      * Shows the local folder a finished download resides in.
      * @param {string} id ID of the download to show.
      */
     show: chromeSendWithId('show'),
 
     /** Undo download removal. */
     undo: chrome.send.bind(chrome, 'undo'),
   };
 
   cr.addSingletonGetter(ActionService);
 
   return {ActionService: ActionService};
 });