Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428833002: Register chrome as a browser when setting the default browser in Win 10 (Closed)

Created:
5 years, 1 month ago by Patrick Monette
Modified:
5 years, 1 month ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register chrome as a browser when setting the default browser in Win 10 BUG= Committed: https://crrev.com/67c85a577dcf192c7f29cba07d4a566536a34950 Cr-Commit-Position: refs/heads/master@{#357177}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/shell_integration_win.cc View 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Patrick Monette
PTAL This mimics what SetAsDefaultBrowserInteractive() does so that the browser registration is done automatically.
5 years, 1 month ago (2015-10-29 17:11:35 UTC) #3
grt (UTC plus 2)
lgtm
5 years, 1 month ago (2015-10-29 19:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428833002/20001
5 years, 1 month ago (2015-10-30 19:12:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-10-30 19:56:33 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:57:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67c85a577dcf192c7f29cba07d4a566536a34950
Cr-Commit-Position: refs/heads/master@{#357177}

Powered by Google App Engine
This is Rietveld 408576698