[es6] Fix Function and GeneratorFunction built-ins subclassing.

[es6] Fix Function and GeneratorFunction built-ins subclassing.

BUG=v8:3101, v8:3330
LOG=Y

Committed: https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a
Cr-Commit-Position: refs/heads/master@{#31708}

[Igor Sheludko, 2015-10-29 15:51:36]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-10-29 15:51:37]

PTAL

[Igor Sheludko, 2015-10-29 19:53:56]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-10-29 19:54:25]

Description was changed from

==========
[es6] Fix Function built-in subclassing.

BUG=v8:3101, v8:3330
LOG=Y
==========

to

==========
[es6] Fix Function and GeneratorFunction built-ins subclassing.

BUG=v8:3101, v8:3330
LOG=Y
==========

[Igor Sheludko, 2015-10-29 22:42:03]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 22:42:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428823002/60001

[commit-bot: I haz the power, 2015-10-29 23:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 23:00:03]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2015-10-30 10:58:02]

lgtm

https://codereview.chromium.org/1428823002/diff/60001/src/js/generator.js
File src/js/generator.js (right):

https://codereview.chromium.org/1428823002/diff/60001/src/js/generator.js#new...
src/js/generator.js:88: // Set name-should-print-as-anonymous flag on the SFI
and ensure that
write out SFI

https://codereview.chromium.org/1428823002/diff/60001/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1428823002/diff/60001/src/js/v8natives.js#new...
src/js/v8natives.js:1801: // Set name-should-print-as-anonymous flag on the SFI
and ensure that
 write out sfi

https://codereview.chromium.org/1428823002/diff/60001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1428823002/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:64: if (!new_target->IsJSFunction() ||
*constructor == *new_target) {
new_target->IsUndefined() ?

[Igor Sheludko, 2015-10-30 11:08:57]

https://codereview.chromium.org/1428823002/diff/60001/src/js/generator.js
File src/js/generator.js (right):

https://codereview.chromium.org/1428823002/diff/60001/src/js/generator.js#new...
src/js/generator.js:88: // Set name-should-print-as-anonymous flag on the SFI
and ensure that
On 2015/10/30 10:58:01, Toon Verwaest wrote:
> write out SFI

Done.

https://codereview.chromium.org/1428823002/diff/60001/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1428823002/diff/60001/src/js/v8natives.js#new...
src/js/v8natives.js:1801: // Set name-should-print-as-anonymous flag on the SFI
and ensure that
On 2015/10/30 10:58:01, Toon Verwaest wrote:
>  write out sfi

Done.

https://codereview.chromium.org/1428823002/diff/60001/src/runtime/runtime-fun...
File src/runtime/runtime-function.cc (right):

https://codereview.chromium.org/1428823002/diff/60001/src/runtime/runtime-fun...
src/runtime/runtime-function.cc:64: if (!new_target->IsJSFunction() ||
*constructor == *new_target) {
On 2015/10/30 10:58:01, Toon Verwaest wrote:
> new_target->IsUndefined() ?

Done.

[Igor Sheludko, 2015-10-30 11:09:02]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-10-30 11:09:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1428823002/#ps80001
(title: "Addressing comments")

[commit-bot: I haz the power, 2015-10-30 11:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428823002/80001

[Igor Sheludko, 2015-10-30 11:39:31]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2015-11-02 10:03:01]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 10:03:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428823002/80001

[commit-bot: I haz the power, 2015-11-02 10:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 10:40:07]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-11-02 11:43:10]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-11-02 11:43:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428823002/80001

[commit-bot: I haz the power, 2015-11-02 11:45:22]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-11-02 11:46:03]

Patchset 4 (id:??) landed as
https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a
Cr-Commit-Position: refs/heads/master@{#31708}

[Igor Sheludko, 2015-11-02 11:58:42]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1413723008/ by ishell@chromium.org.

The reason for reverting is: Buildbot failures.

[Michael Achenbach, 2015-11-02 12:53:15]

Hmm - how did this pass the Check step on linux64? Was the dry run made on an
older HEAD? Maybe the HEAD changed by the time of committing, the old tryjob
result got reused and now with the newest code there are undetected test
failures...

[Igor Sheludko, 2015-11-02 12:59:01]

On 2015/11/02 12:53:15, Michael Achenbach wrote:
> Hmm - how did this pass the Check step on linux64? Was the dry run made on an
> older HEAD? Maybe the HEAD changed by the time of committing, the old tryjob
> result got reused and now with the newest code there are undetected test
> failures...

Could it be related to the fact that this patch set depends on another one?