util/win/exception_handler_server_test.cc - Issue 1428803006: win: Implement CrashpadClient::StartHandler()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/win/exception_handler_server_test.cc

Issue 1428803006: win: Implement CrashpadClient::StartHandler() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback; add a test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/win/exception_handler_server_test.cc

diff --git a/util/win/exception_handler_server_test.cc b/util/win/exception_handler_server_test.cc

index 9fe593b5b155c68f72f047eb2dd6a930e031c4d7..c1e5d7f4bcaf5128f713a5669ba2ad56272804af 100644

--- a/util/win/exception_handler_server_test.cc

+++ b/util/win/exception_handler_server_test.cc

@@ -83,7 +83,7 @@ class ExceptionHandlerServerTest : public testing::Test {

base::StringPrintf("%08x", GetCurrentProcessId())),

server_ready_(CreateEvent(nullptr, false, false, nullptr)),

delegate_(server_ready_.get()),

- server_(pipe_name_),

+ server_(pipe_name_, true),

server_thread_(&server_, &delegate_) {}

TestDelegate& delegate() { return delegate_; }

« no previous file with comments | « util/win/exception_handler_server.cc ('k') | util/win/process_info_test.cc » ('j') | no next file with comments »