Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: util/win/command_line.cc

Issue 1428803006: win: Implement CrashpadClient::StartHandler() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback; add a test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/win/command_line.h ('k') | util/win/command_line_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/command_line.cc
diff --git a/util/win/command_line.cc b/util/win/command_line.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5829c12d83255c58d56039b4ed89e93e03c7329a
--- /dev/null
+++ b/util/win/command_line.cc
@@ -0,0 +1,58 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/win/command_line.h"
+
+namespace crashpad {
+
+// Ref:
+// http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx
+void AppendCommandLineArgument(const std::wstring& argument,
+ std::wstring* command_line) {
+ if (!command_line->empty()) {
+ command_line->push_back(L' ');
+ }
+
+ // Don’t bother quoting if unnecessary.
+ if (!argument.empty() &&
+ argument.find_first_of(L" \t\n\v\"") == std::wstring::npos) {
+ command_line->append(argument);
+ } else {
+ command_line->push_back(L'"');
+ for (std::wstring::const_iterator i = argument.begin();; ++i) {
+ size_t backslash_count = 0;
+ while (i != argument.end() && *i == L'\\') {
+ ++i;
+ ++backslash_count;
+ }
+ if (i == argument.end()) {
+ // Escape all backslashes, but let the terminating double quotation mark
+ // we add below be interpreted as a metacharacter.
+ command_line->append(backslash_count * 2, L'\\');
+ break;
+ } else if (*i == L'"') {
+ // Escape all backslashes and the following double quotation mark.
+ command_line->append(backslash_count * 2 + 1, L'\\');
+ command_line->push_back(*i);
+ } else {
+ // Backslashes aren’t special here.
+ command_line->append(backslash_count, L'\\');
+ command_line->push_back(*i);
+ }
+ }
+ command_line->push_back(L'"');
+ }
+}
+
+} // namespace crashpad
« no previous file with comments | « util/win/command_line.h ('k') | util/win/command_line_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698