win: Implement CrashpadClient::StartHandler()

test/win/child_launcher.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "test/win/child_launcher.h"
 
 #include "gtest/gtest.h"
+#include "util/win/command_line.h"
 
 namespace crashpad {
 namespace test {
 
 ChildLauncher::ChildLauncher(const std::wstring& executable,
                              const std::wstring& command_line)
     : executable_(executable),
       command_line_(command_line),
       process_handle_(),
       main_thread_handle_(),
@@ skipping 34 matching lines @@
 
   STARTUPINFO startup_info = {0};
   startup_info.cb = sizeof(startup_info);
   startup_info.hStdInput = read_handle.get();
   startup_info.hStdOutput = write_handle.get();
   startup_info.hStdError = GetStdHandle(STD_ERROR_HANDLE);
   startup_info.dwFlags = STARTF_USESTDHANDLES;
   PROCESS_INFORMATION process_information;
   std::wstring command_line;
   AppendCommandLineArgument(executable_, &command_line);
   command_line += L" ";

[scottmg, 2015/10/30 23:16:31]

Hmm, this is unfortunate. Oh well.

   command_line += command_line_;
   ASSERT_TRUE(CreateProcess(executable_.c_str(),
                             &command_line[0],
                             nullptr,
                             nullptr,
                             true,
                             0,
                             nullptr,
                             nullptr,
                             &startup_info,
                             &process_information));
   // Take ownership of the two process handles returned.
   main_thread_handle_.reset(process_information.hThread);
   process_handle_.reset(process_information.hProcess);
 }
 
 DWORD ChildLauncher::WaitForExit() {
   EXPECT_TRUE(process_handle_.is_valid());
   EXPECT_EQ(WAIT_OBJECT_0,
             WaitForSingleObject(process_handle_.get(), INFINITE));
   DWORD exit_code = 0;
   EXPECT_TRUE(GetExitCodeProcess(process_handle_.get(), &exit_code));
   process_handle_.reset();
   return exit_code;
 }
 
-// Ref: http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx
-void AppendCommandLineArgument(const std::wstring& argument,
-                               std::wstring* command_line) {
-  // Don't bother quoting if unnecessary.
-  if (!argument.empty() &&
-      argument.find_first_of(L" \t\n\v\"") == std::wstring::npos) {
-    command_line->append(argument);
-  } else {
-    command_line->push_back(L'"');
-    for (std::wstring::const_iterator i = argument.begin();; ++i) {
-      size_t backslash_count = 0;
-      while (i != argument.end() && *i == L'\\') {
-        ++i;
-        ++backslash_count;
-      }
-      if (i == argument.end()) {
-        // Escape all backslashes, but let the terminating double quotation mark
-        // we add below be interpreted as a metacharacter.
-        command_line->append(backslash_count * 2, L'\\');
-        break;
-      } else if (*i == L'"') {
-        // Escape all backslashes and the following double quotation mark.
-        command_line->append(backslash_count * 2 + 1, L'\\');
-        command_line->push_back(*i);
-      } else {
-        // Backslashes aren't special here.
-        command_line->append(backslash_count, L'\\');
-        command_line->push_back(*i);
-      }
-    }
-    command_line->push_back(L'"');
-  }
-}
-
 }  // namespace test
 }  // namespace crashpad