Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1428803004: Revert "Compute propagated type for final instance fields (partially addresses issue 23001)" (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, Leaf
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Compute propagated type for final instance fields (partially addresses issue 23001)" R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/a7f2f5b4e1b741239da42b48ce257cba4f13fada

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -111 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +5 lines, -47 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +64 lines, -64 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
There is an order dependency when references in subclasses are processed before field declarations in ...
5 years, 1 month ago (2015-10-29 20:59:23 UTC) #2
Paul Berry
lgtm
5 years, 1 month ago (2015-10-29 21:00:40 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-10-29 21:02:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7f2f5b4e1b741239da42b48ce257cba4f13fada (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698