third_party/WebKit/Source/core/html/HTMLMeterElement.cpp - Issue 1428703004: Make <meter> transparent if -webkit-appearance:none or background CSS property is specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

Issue 1428703004: Make <meter> transparent if -webkit-appearance:none or background CSS property is specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html ('k') | third_party/WebKit/Source/core/html/shadow/MeterShadowElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp b/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

index 97587fa12436bb251c3af6388e18a70ad298107d..22062d43472d6d4face66da416a0e942e64f49e3 100644

--- a/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp

@@ -29,6 +29,7 @@

#include "core/dom/ExceptionCode.h"

#include "core/dom/shadow/ShadowRoot.h"

#include "core/frame/UseCounter.h"

+#include "core/html/HTMLContentElement.h"

#include "core/html/parser/HTMLParserIdioms.h"

#include "core/html/shadow/MeterShadowElement.h"

#include "core/layout/LayoutMeter.h"

@@ -209,6 +210,10 @@ void HTMLMeterElement::didAddUserAgentShadowRoot(ShadowRoot& root)

bar->appendChild(m_value);

inner->appendChild(bar);

+ RefPtrWillBeRawPtr<MeterFallbackElement> fallback = MeterFallbackElement::create(document());

+ fallback->appendChild(HTMLContentElement::create(document()));

+ root.appendChild(fallback.release());

}

void HTMLMeterElement::willAddFirstAuthorShadowRoot()