Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 1428703004: Make <meter> transparent if -webkit-appearance:none or background CSS property is specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MeterShadowElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 return appearance != CheckboxPart && appearance != RadioPart; 383 return appearance != CheckboxPart && appearance != RadioPart;
384 } 384 }
385 385
386 bool LayoutTheme::isControlStyled(const ComputedStyle& style) const 386 bool LayoutTheme::isControlStyled(const ComputedStyle& style) const
387 { 387 {
388 switch (style.appearance()) { 388 switch (style.appearance()) {
389 case PushButtonPart: 389 case PushButtonPart:
390 case SquareButtonPart: 390 case SquareButtonPart:
391 case ButtonPart: 391 case ButtonPart:
392 case ProgressBarPart: 392 case ProgressBarPart:
393 case MeterPart:
394 case RelevancyLevelIndicatorPart: 393 case RelevancyLevelIndicatorPart:
395 case ContinuousCapacityLevelIndicatorPart: 394 case ContinuousCapacityLevelIndicatorPart:
396 case DiscreteCapacityLevelIndicatorPart: 395 case DiscreteCapacityLevelIndicatorPart:
397 case RatingLevelIndicatorPart: 396 case RatingLevelIndicatorPart:
398 return style.hasAuthorBackground() || style.hasAuthorBorder(); 397 return style.hasAuthorBackground() || style.hasAuthorBorder();
399 398
399 case MeterPart:
400 return style.hasAuthorBackground();
401
400 case MenulistPart: 402 case MenulistPart:
401 case SearchFieldPart: 403 case SearchFieldPart:
402 case TextAreaPart: 404 case TextAreaPart:
403 case TextFieldPart: 405 case TextFieldPart:
404 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow(); 406 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow();
405 407
406 case SliderHorizontalPart: 408 case SliderHorizontalPart:
407 case SliderVerticalPart: 409 case SliderVerticalPart:
408 return style.boxShadow(); 410 return style.boxShadow();
409 411
(...skipping 527 matching lines...) Expand 10 before | Expand all | Expand 10 after
937 939
938 // padding - not honored by WinIE, needs to be removed. 940 // padding - not honored by WinIE, needs to be removed.
939 style.resetPadding(); 941 style.resetPadding();
940 942
941 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 943 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
942 // for now, we will not honor it. 944 // for now, we will not honor it.
943 style.resetBorder(); 945 style.resetBorder();
944 } 946 }
945 947
946 } // namespace blink 948 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MeterShadowElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698