chrome/browser/chrome_browser_main_win.cc - Issue 14287008: Refactoring installer shortcut deletion; adding dedicated shortcut update feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 14287008: Refactoring installer shortcut deletion; adding dedicated shortcut update feature. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed redundant routines; cleaning up interfaces, including fixing callers. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main_win.cc

diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc

index e8cd5933c25a34dddd77357d4cf58d020d78555a..d5e09d82b614067dd3ba9b5c7d8b3cfdfeb98c86 100644

--- a/chrome/browser/chrome_browser_main_win.cc

+++ b/chrome/browser/chrome_browser_main_win.cc

@@ -145,8 +145,7 @@ int DoUninstallTasks(bool chrome_still_running) {

BrowserDistribution* dist = BrowserDistribution::GetDistribution();

for (size_t i = 0; i < arraysize(user_shortcut_locations); ++i) {

if (!ShellUtil::RemoveShortcut(user_shortcut_locations[i], dist,

- chrome_exe, ShellUtil::CURRENT_USER,

- NULL)) {

+ ShellUtil::CURRENT_USER, chrome_exe)) {

VLOG(1) << "Failed to delete shortcut at location "

<< user_shortcut_locations[i];

}

« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/uninstall.cc » ('J')