Refactoring installer shortcut deletion; adding dedicated shortcut update feature.

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 495 matching lines @@
   // location; otherwise remove all shortcuts to |target_exe| at |location|.
   // If |location| is SHORTCUT_LOCATION_START_MENU, the shortcut folder specific
   // to |dist| is deleted.
   // Also attempts to unpin the removed shortcut(s) from the taskbar.
   // Returns true if the shortcut(s) were successfully deleted (or there were
   // none at |location| pointing to |target_exe|).
   static bool RemoveShortcut(ShellUtil::ShortcutLocation location,
                              BrowserDistribution* dist,
                              const base::FilePath& target_exe,
                              ShellChange level,
                              const string16* shortcut_name);

[gab, 2013/04/24 21:41:46]

I like the idea of using a pattern here instead of using NULL to mean all
shortcuts.

[huangs, 2013/04/25 16:27:46]

Changing interface:
The old routine is now RemoveShortcutWithName(), and by default RemoveShortcut()
removes all shortcuts (made into an adaptor).  This way  we can keep the details
w.r.t. "*" vs. NULL internal to ShellUtil.

 
   // Enumerates all shortcuts pinned to the taskbar and deletes those pointing
   // to |target_exe|.
   // base::win::TaskbarUnpinShortcutLink() should be prefered, but this is
   // useful on uninstall as the parent shortcut of a pin might no longer exist
   // (thus making it impossible to unpin it via that API).
   static void RemoveTaskbarShortcuts(const string16& target_exe);
 
   // This will remove all secondary tiles from the start screen for |dist|.
   static void RemoveStartScreenShortcuts(BrowserDistribution* dist,
                                          const string16& target_exe);
 
+  // Traverses through instsalles shortcut(s) in a similar fashion as

[gab, 2013/04/24 21:41:46]

nit: instsalles ?!

[huangs, 2013/04/25 16:27:46]

installed.  Done.

+  // RemoveShortcut(). For each matched shortcut to |old_target_exe|,
+  // update the shortcut so that it points to |new_target_exe|.
+  static bool MigrateShortcut(ShellUtil::ShortcutLocation location,
+                              BrowserDistribution* dist,
+                              const base::FilePath& old_target_exe,
+                              const base::FilePath& new_target_exe,
+                              ShellChange level,
+                              const string16* shortcut_name);
+
+  // Simmilar to RemoveTaskbarShortcuts(), but performs migration.
+  static void MigrateTaskbarShortcuts(const string16& old_target_exe,
+                                      const string16& new_target_exe);
+
+  // Simmilar to RemoveStartScreenShortcuts(), but performs migration.
+  static void MigrateStartScreenShortcuts(BrowserDistribution* dist,
+                                          const string16& old_target_exe,
+                                          const string16& new_target_exe);
+
   // Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
   // preceded by a dot.
   // This is guaranteed to be unique on the machine and 27 characters long
   // (including the '.').
   // This suffix is then meant to be added to all registration that may conflict
   // with another user-level Chrome install.
   // Note that prior to Chrome 21, the suffix registered used to be the user's
   // username (see GetOldUserSpecificRegistrySuffix() below). We still honor old
   // installs registered that way, but it was wrong because some of the
   // characters allowed in a username are not allowed in a ProgId.
@@ skipping 16 matching lines @@
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_