Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: src/heap/heap.cc

Issue 1428683002: [heap] Convert overapproximate weak closure phase into finalize incremental marking phase and revis… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index ba5545b14c3cc7ac2ea1b95b050d7e25da2e86fe..5b39a427d7ea0887d6695cdb8fd807def9fdbe97 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -774,7 +774,7 @@ void Heap::HandleGCRequest() {
current_gc_callback_flags_);
return;
}
- DCHECK(FLAG_overapproximate_weak_closure);
+ DCHECK(FLAG_finalize_marking_incrementally);
if (!incremental_marking()->weak_closure_was_overapproximated()) {
OverApproximateWeakClosure("GC interrupt");
}
@@ -805,7 +805,7 @@ void Heap::OverApproximateWeakClosure(const char* gc_reason) {
CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags);
}
}
- incremental_marking()->MarkObjectGroups();
+ incremental_marking()->FinalizeIncrementally();
{
GCCallbacksScope scope(this);
if (scope.CheckReenter()) {
@@ -4071,7 +4071,8 @@ void Heap::ReduceNewSpaceSize() {
void Heap::FinalizeIncrementalMarkingIfComplete(const char* comment) {
- if (FLAG_overapproximate_weak_closure && incremental_marking()->IsMarking() &&
+ if (FLAG_finalize_marking_incrementally &&
+ incremental_marking()->IsMarking() &&
(incremental_marking()->IsReadyToOverApproximateWeakClosure() ||
(!incremental_marking()->weak_closure_was_overapproximated() &&
mark_compact_collector()->marking_deque()->IsEmpty()))) {
@@ -4088,7 +4089,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) {
size_t final_incremental_mark_compact_speed_in_bytes_per_ms =
static_cast<size_t>(
tracer()->FinalIncrementalMarkCompactSpeedInBytesPerMillisecond());
- if (FLAG_overapproximate_weak_closure &&
+ if (FLAG_finalize_marking_incrementally &&
(incremental_marking()->IsReadyToOverApproximateWeakClosure() ||
(!incremental_marking()->weak_closure_was_overapproximated() &&
mark_compact_collector()->marking_deque()->IsEmpty() &&

Powered by Google App Engine
This is Rietveld 408576698