[heap] Convert overapproximate weak closure phase into finalize incremental marking phase and revis…

[heap] Convert overapproximate weak closure phase into finalize incremental marking phase and revisit the root set there.

BUG=chromium:548562
LOG=n

Committed: https://crrev.com/6074b326083b77a64267c0e346ff06a9c1e413dd
Cr-Commit-Position: refs/heads/master@{#31627}

[Hannes Payer (out of office), 2015-10-28 09:27:06]

hpayer@chromium.org changed reviewers:
+ jochen@chromium.org, ulan@chromium.org

[jochen (gone - plz use gerrit), 2015-10-28 09:29:08]

lgtm

[ulan, 2015-10-28 10:36:19]

lgtm

Please rename Heap::OverApproximateWeakClosure too.

https://codereview.chromium.org/1428683002/diff/20001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/1428683002/diff/20001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:650: void
IncrementalMarking::FinalizeIncrementally() {
We are not tracking this pause in any of the histograms.

[Hannes Payer (out of office), 2015-10-28 11:42:54]

Renamed. Thanks for the comments.

https://codereview.chromium.org/1428683002/diff/20001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/1428683002/diff/20001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:650: void
IncrementalMarking::FinalizeIncrementally() {
On 2015/10/28 10:36:19, ulan wrote:
> We are not tracking this pause in any of the histograms.

Good point! I will do that in a separate CL.

[Hannes Payer (out of office), 2015-10-28 11:44:14]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-10-28 11:44:15]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1428683002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-10-28 11:44:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428683002/40001

[commit-bot: I haz the power, 2015-10-28 12:05:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-28 12:06:07]

Patchset 3 (id:??) landed as
https://crrev.com/6074b326083b77a64267c0e346ff06a9c1e413dd
Cr-Commit-Position: refs/heads/master@{#31627}