Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1428673005: win/clang: Fix a -Wmicrosoft-cast warning. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, majnemer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/clang: Fix a -Wmicrosoft-cast warning. http://llvm.org/viewvc/llvm-project?view=revision&revision=251738 let clang warn on converting function pointers to object pointers. Fix one such instance. No intended behavior change. Fixes ..\..\chrome\...\verifier_test_dll.cc(24,19) : error: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] g_somestate = &DummyExport; ^~~~~~~~~~~~ BUG=82385 Committed: https://crrev.com/51ca06cec30b81d20c1360abeca8e57b4b9a6040 Cr-Commit-Position: refs/heads/master@{#357281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
5 years, 1 month ago (2015-11-01 00:45:43 UTC) #2
robertshield
lgtm
5 years, 1 month ago (2015-11-01 02:04:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428673005/1
5 years, 1 month ago (2015-11-01 02:52:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-01 02:55:26 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-01 02:56:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51ca06cec30b81d20c1360abeca8e57b4b9a6040
Cr-Commit-Position: refs/heads/master@{#357281}

Powered by Google App Engine
This is Rietveld 408576698