Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1428673004: Rework codegen tools to avoid relying on CWD; integrate with task model graph. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework codegen tools to avoid relying on CWD; integrate with task model graph. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/06ef697a0b93b39a34a65dcfedf7d72b4a96091d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -93 lines) Patch
M pkg/analyzer/lib/src/codegen/tools.dart View 8 chunks +54 lines, -51 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/check_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 6 chunks +10 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-10-29 18:04:26 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-29 18:40:27 UTC) #3
Paul Berry
5 years, 1 month ago (2015-10-29 20:12:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06ef697a0b93b39a34a65dcfedf7d72b4a96091d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698