PPAPI: Remove PPB_Font_Dev.

PPAPI: Remove PPB_Font_Dev.

TBR=brettw@chromium.org

Committed: https://crrev.com/d8ecc8472dc7cef04a6a529786649e87b0d1d35e
Cr-Commit-Position: refs/heads/master@{#357449}

[Lei Zhang, 2015-10-28 02:55:38]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-10-28 04:15:48]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2015-10-28 04:44:15]

Patchset #1 (id:40001) has been deleted

[Lei Zhang, 2015-10-28 05:10:13]

Patchset #1 (id:60001) has been deleted

[Lei Zhang, 2015-10-28 05:13:22]

thestig@chromium.org changed reviewers:
+ brettw@chromium.org

[Lei Zhang, 2015-10-28 05:13:23]

https://codereview.chromium.org/1428653002/diff/80001/ppapi/cpp/trusted/brows...
File ppapi/cpp/trusted/browser_font_trusted.cc (left):

https://codereview.chromium.org/1428653002/diff/80001/ppapi/cpp/trusted/brows...
ppapi/cpp/trusted/browser_font_trusted.cc:29: // TODO(brettw) remove PPB_Font
altogether when Flash is updated.
Has Flash been updated? This TODO is 3.5 years old. Please say yes. :)

[Lei Zhang, 2015-10-28 06:05:48]

+ppapi/OWNERS too

[binji, 2015-10-29 18:00:07]

binji@chromium.org changed reviewers:
+ bbudge@chromium.org, binji@chromium.org

[binji, 2015-10-29 18:00:41]

On 2015/10/29 at 18:00:08, binji wrote:
> 

+bbudge

native_client_sdk lgtm

[bbudge, 2015-10-30 17:22:59]

LGTM  if Brett or someone else can confirm Flash moved off it.

[Lei Zhang, 2015-10-30 17:27:58]

On 2015/10/30 17:22:59, bbudge wrote:
> LGTM  if Brett or someone else can confirm Flash moved off it.

ihf: can you confirm? ^

[ilja, 2015-11-02 20:00:31]

ihf@chromium.org changed reviewers:
+ ihf@chromium.org, xzhang@adobe.com

[ihf, 2015-11-02 20:05:13]

ihf@google.com changed reviewers:
+ ihf@google.com

[ihf, 2015-11-02 20:05:14]

LGTM. Flash doesn't use this interface anymore. Still, adding Xing to verify
that there are no old (debugger etc) binaries which would need it. Also FYI as
it touches some files in his change.

[Xing, 2015-11-02 20:12:32]

On 2015/11/02 20:05:14, ihf wrote:
> LGTM. Flash doesn't use this interface anymore. Still, adding Xing to verify
> that there are no old (debugger etc) binaries which would need it. Also FYI as
> it touches some files in his change.

Flash only uses PPB_BrowserFont_Trusted and PPB_Flash PPAPI for text rendering,
it does not use Font_Dev interface.

[Lei Zhang, 2015-11-02 21:20:54]

On 2015/11/02 20:12:32, Xing wrote:
> On 2015/11/02 20:05:14, ihf wrote:
> > LGTM. Flash doesn't use this interface anymore. Still, adding Xing to verify
> > that there are no old (debugger etc) binaries which would need it. Also FYI
as
> > it touches some files in his change.
> 
> Flash only uses PPB_BrowserFont_Trusted and PPB_Flash PPAPI for text
rendering,
> it does not use Font_Dev interface.

Thanks for the feedback. Sounds like we are good to go.

[Lei Zhang, 2015-11-02 21:21:07]

Description was changed from

==========
PPAPI: Remove PPB_Font_Dev.
==========

to

==========
PPAPI: Remove PPB_Font_Dev.

TBR=brettw@chromium.org
==========

[Lei Zhang, 2015-11-02 21:21:32]

TBR brettw@ for the rest, which is just
content/child/browser_font_resource_trusted.cc according to git cl presubmit.

[Lei Zhang, 2015-11-02 21:21:39]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-11-02 21:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
ihf@google.com, binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1428653002/#ps90001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-02 21:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428653002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428653002/90001

[commit-bot: I haz the power, 2015-11-02 22:29:13]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2015-11-02 22:29:54]

Patchset 2 (id:??) landed as
https://crrev.com/d8ecc8472dc7cef04a6a529786649e87b0d1d35e
Cr-Commit-Position: refs/heads/master@{#357449}