third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp - Issue 1428643004: Repaint on interest rect change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

Issue 1428643004: Repaint on interest rect change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableSyncPaint

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

index b5f81f798f767d368b26c32d322d6359d050fbd7..5195082bcfda209c3a91d60367272dbb709cd553 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

@@ -141,7 +141,7 @@ TEST_P(PaintLayerPainterTest, CachedSubsequenceOnInterestRectChange)

PaintLayer& container3Layer = *toLayoutBoxModelObject(container3).layer();

LayoutObject& content3 = *document().getElementById("content3")->layoutObject();

- LayoutRect interestRect(0, 0, 400, 300);

+ IntRect interestRect(0, 0, 400, 300);

document().view()->updateAllLifecyclePhases(&interestRect);

// Container1 is fully in the interest rect;

@@ -186,7 +186,7 @@ TEST_P(PaintLayerPainterTest, CachedSubsequenceOnInterestRectChange)

TestDisplayItem(rootLayer, endSubsequenceType));

}

- LayoutRect newInterestRect(0, 100, 300, 300);

+ IntRect newInterestRect(0, 100, 300, 300);

document().view()->updateAllLifecyclePhases(&newInterestRect);

// Container1 becomes partly in the interest rect, but uses cached subsequence

@@ -343,7 +343,7 @@ TEST_F(PaintLayerPainterTestForSlimmingPaintV2, CachedSubsequenceOnInterestRectC

PaintLayer& container3Layer = *toLayoutBoxModelObject(container3).layer();

LayoutObject& content3 = *document().getElementById("content3")->layoutObject();

- LayoutRect interestRect(0, 0, 400, 300);

+ IntRect interestRect(0, 0, 400, 300);

document().view()->updateAllLifecyclePhases(&interestRect);

// Container1 is fully in the interest rect;

@@ -374,7 +374,7 @@ TEST_F(PaintLayerPainterTestForSlimmingPaintV2, CachedSubsequenceOnInterestRectC

// Container2's intersection with the interest rect changes;

// Content2b is out of the interest rect and outputs nothing;

// Container3 becomes out of the interest rect and outputs nothing.

- LayoutRect newInterestRect(0, 100, 300, 300);

+ IntRect newInterestRect(0, 100, 300, 300);

updateLifecyclePhasesToPaintClean(&newInterestRect);

EXPECT_DISPLAY_LIST(rootPaintController().newDisplayItemList(), 11,