Repaint on interest rect change

third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

 /*
  * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 2184 matching lines @@
     if (!visibleContentRect.isEmpty()) {
         localInterestRect = owningLayoutObject->absoluteToLocalQuad(FloatRect(visibleContentRect), UseTransforms).enclosingBoundingBox();
         localInterestRect.move(-graphicsLayer->offsetFromLayoutObject());
     }
     // Expand by interest rect padding amount.
     localInterestRect.expand(IntRectOutsets(kPixelDistanceToRecord, kPixelDistanceToRecord, kPixelDistanceToRecord, kPixelDistanceToRecord));
     localInterestRect.intersect(enclosingIntRect(graphicsLayerBounds));
     return localInterestRect;
 }
 
-void CompositedLayerMapping::paintContentsIfNeeded(const GraphicsLayer* graphicsLayer, GraphicsContext& context, GraphicsLayerPaintingPhase graphicsLayerPaintingPhase) const
+static bool changedSufficiently(int newValue, int previousValue, int baseValue)
 {
-    ASSERT(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled());
+    return std::abs(newValue - previousValue) * 16 < baseValue;
+}
 
-    // TODO(chrishtr): Also paint if the interest rect has changed sufficiently.
-    if (!m_owningLayer.needsRepaint()) {
-        context.paintController().createAndAppend<CachedDisplayItem>(*this, DisplayItem::CachedDisplayItemList);
-        return;
+static bool interestRectChangeNeedsRepaint(const IntRect& newInterestRect, const IntRect& previousInterestRect)

[chrishtr, 2015/10/28 21:03:54]

This is a little different than what DisplayListRecordingSource does. We should
just copy the logic exactly.

Also, rename to interestChangedEnoughToNeedRepaint.

[Xianzhu, 2015/10/29 01:55:09]

Done.

+{
+    if (previousInterestRect.contains(newInterestRect))
+        return false;
+    return changedSufficiently(newInterestRect.x(), previousInterestRect.x(), previousInterestRect.width())
+        || changedSufficiently(newInterestRect.y(), previousInterestRect.y(), previousInterestRect.height())
+        || changedSufficiently(newInterestRect.maxX(), previousInterestRect.maxX(), previousInterestRect.width())
+        || changedSufficiently(newInterestRect.maxY(), previousInterestRect.maxY(), previousInterestRect.height());
+}
+
+void CompositedLayerMapping::paintContents(const GraphicsLayer* graphicsLayer, GraphicsContext& context, GraphicsLayerPaintingPhase graphicsLayerPaintingPhase, const IntRect* interestRect) const
+{
+    IntRect defaultInterestRect;
+    if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
+        if (!interestRect) {
+            if (graphicsLayer == m_graphicsLayer || graphicsLayer == m_squashingLayer)
+                defaultInterestRect = computeInterestRect(graphicsLayer, m_owningLayer.layoutObject());
+            else
+                defaultInterestRect = enclosingIntRect(FloatRect(FloatPoint(), graphicsLayer->size()));
+            interestRect = &defaultInterestRect;
+        }
+
+        if (!m_owningLayer.needsRepaint()
+            && context.paintController().clientCacheIsValid(m_owningLayer.displayItemClient())
+            && !interestRectChangeNeedsRepaint(*interestRect, m_previousPaintInterestRect)) {
+            context.paintController().createAndAppend<CachedDisplayItem>(*this, DisplayItem::CachedDisplayItemList);
+            return;
+
+        m_previousPaintInterestRect = *interestRect;
     }
 
-    IntRect interestRect;
-    if (graphicsLayer == m_graphicsLayer || graphicsLayer == m_squashingLayer)
-        interestRect = computeInterestRect(graphicsLayer, m_owningLayer.layoutObject());
-    else
-        interestRect = enclosingIntRect(FloatRect(FloatPoint(), graphicsLayer->size()));
-
-    paintContents(graphicsLayer, context, graphicsLayerPaintingPhase, interestRect);
+    ASSERT(interestRect);
+    paintContentsInternal(graphicsLayer, context, graphicsLayerPaintingPhase, *interestRect);
 }
 
-void CompositedLayerMapping::paintContents(const GraphicsLayer* graphicsLayer, GraphicsContext& context, GraphicsLayerPaintingPhase graphicsLayerPaintingPhase, const IntRect& interestRect) const
+void CompositedLayerMapping::paintContentsInternal(const GraphicsLayer* graphicsLayer, GraphicsContext& context, GraphicsLayerPaintingPhase graphicsLayerPaintingPhase, const IntRect& interestRect) const
 {
     // https://code.google.com/p/chromium/issues/detail?id=343772
     DisableCompositingQueryAsserts disabler;
 #if ENABLE(ASSERT)
     // FIXME: once the state machine is ready, this can be removed and we can refer to that instead.
     if (Page* page = layoutObject()->frame()->page())
         page->setIsPainting(true);
 #endif
 
     TRACE_EVENT1("devtools.timeline", "Paint", "data", InspectorPaintEvent::data(m_owningLayer.layoutObject(), LayoutRect(interestRect), graphicsLayer));
@@ skipping 225 matching lines @@
     } else if (graphicsLayer == m_scrollingBlockSelectionLayer.get()) {
         name = "Scrolling Block Selection Layer";
     } else {
         ASSERT_NOT_REACHED();
     }
 
     return name;
 }
 
 } // namespace blink