Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428633003: Wire up SDL on mac (Closed)

Created:
5 years, 1 month ago by joshualitt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -67 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/views.gyp View 1 4 chunks +28 lines, -5 lines 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 1 chunk +3 lines, -1 line 0 comments Download
A + third_party/libsdl/mac/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/libsdl/mac/SDL_config.h View 8 chunks +38 lines, -38 lines 0 comments Download
A + third_party/libsdl/mac/sdl_mac.gypi View 2 chunks +36 lines, -24 lines 0 comments Download
M third_party/libsdl/sdl.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joshualitt
I'm sure I'm inadvertently creating bitrot as I go, gonna be nice to have this ...
5 years, 1 month ago (2015-11-09 19:33:08 UTC) #2
robertphillips
lgtm - but gyp isn't my forte
5 years, 1 month ago (2015-11-09 19:40:40 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-11-09 19:41:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428633003/20001
5 years, 1 month ago (2015-11-09 20:12:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 20:30:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/47fdae9807c559e8b9f6ddff26cd34de03441594

Powered by Google App Engine
This is Rietveld 408576698