Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/renderer/resources/extensions/event.js

Issue 142863006: Remove detach_ as publicly exposed method of Event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/extensions/event_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var eventNatives = requireNative('event_natives'); 5 var eventNatives = requireNative('event_natives');
6 var logging = requireNative('logging'); 6 var logging = requireNative('logging');
7 var schemaRegistry = requireNative('schema_registry'); 7 var schemaRegistry = requireNative('schema_registry');
8 var sendRequest = require('sendRequest').sendRequest; 8 var sendRequest = require('sendRequest').sendRequest;
9 var utils = require('utils'); 9 var utils = require('utils');
10 var validate = require('schemaUtils').validate; 10 var validate = require('schemaUtils').validate;
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 'hasListeners', 513 'hasListeners',
514 'getListenerCount', 514 'getListenerCount',
515 'dispatchToListener', 515 'dispatchToListener',
516 'dispatch', 516 'dispatch',
517 'addRules', 517 'addRules',
518 'removeRules', 518 'removeRules',
519 'getRules', 519 'getRules',
520 // TODO(fsamuel): We really shouldn't be exposing these private methods 520 // TODO(fsamuel): We really shouldn't be exposing these private methods
521 // but certain tests rely on them. 521 // but certain tests rely on them.
522 'attach_', 522 'attach_',
523 'detach_',
524 'dispatch_' 523 'dispatch_'
525 ]); 524 ]);
526 525
527 // NOTE: Event is (lazily) exposed as chrome.Event from dispatcher.cc. 526 // NOTE: Event is (lazily) exposed as chrome.Event from dispatcher.cc.
528 exports.Event = Event; 527 exports.Event = Event;
529 528
530 exports.dispatchEvent = dispatchEvent; 529 exports.dispatchEvent = dispatchEvent;
531 exports.parseEventOptions = parseEventOptions; 530 exports.parseEventOptions = parseEventOptions;
532 exports.registerArgumentMassager = registerArgumentMassager; 531 exports.registerArgumentMassager = registerArgumentMassager;
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/event_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698