Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142863003: Show IP address in DevTools. (Closed)

Created:
6 years, 11 months ago by eustas
Modified:
6 years, 10 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Show IP address in DevTools. BUG=255602 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166024

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed copy-paste + added field to detailed view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkManager.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 7 chunks +28 lines, -1 line 0 comments Download
M Source/devtools/front_end/NetworkRequest.js View 1 2 chunks +21 lines, -0 lines 0 comments Download
M Source/devtools/front_end/RequestHeadersView.js View 1 4 chunks +17 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eustas
6 years, 11 months ago (2014-01-27 12:20:23 UTC) #1
cbentzel
I amodified RequestHeadersView.js in my local patch, not sure if you want to put that ...
6 years, 11 months ago (2014-01-27 18:46:35 UTC) #2
Peter Beverloo
https://codereview.chromium.org/142863003/diff/1/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/142863003/diff/1/Source/devtools/front_end/NetworkPanel.js#newcode381 Source/devtools/front_end/NetworkPanel.js:381: this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RemoteAddressComparator; drive-by: s/type/remoteAddress/
6 years, 11 months ago (2014-01-27 19:03:26 UTC) #3
eustas
On 2014/01/27 18:46:35, cbentzel wrote: > I amodified RequestHeadersView.js in my local patch, not sure ...
6 years, 10 months ago (2014-01-28 10:19:35 UTC) #4
eustas
https://codereview.chromium.org/142863003/diff/1/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/142863003/diff/1/Source/devtools/front_end/NetworkPanel.js#newcode381 Source/devtools/front_end/NetworkPanel.js:381: this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RemoteAddressComparator; On 2014/01/27 19:03:26, Peter Beverloo wrote: ...
6 years, 10 months ago (2014-01-28 10:41:09 UTC) #5
vsevik
lgtm
6 years, 10 months ago (2014-01-29 07:53:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/142863003/40001
6 years, 10 months ago (2014-01-29 13:00:28 UTC) #7
commit-bot: I haz the power
Change committed as 166024
6 years, 10 months ago (2014-01-29 16:11:43 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 16:15:29 UTC) #9
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698