Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1428593005: Add test for StringToCode and StringToWideString. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for StringToCode and StringToWideString This CL adds a test case for the StringToCode and StringToWideString methods in fpdf_font.cpp. In order to do so, it moves the methods to be private methods of CPDF_ToUnicodeMap and make the tests friends of the class. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/52b0b525dca3d982a04b77fa6d0913aff1e5fd9c

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 2 9 chunks +17 lines, -11 lines 0 comments Download
A core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL. I believe I covered all the cases for these two methods. Please let me ...
5 years, 1 month ago (2015-11-02 17:54:21 UTC) #2
Tom Sepez
https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_font/font_int.h File core/src/fpdfapi/fpdf_font/font_int.h (right): https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_font/font_int.h#newcode182 core/src/fpdfapi/fpdf_font/font_int.h:182: FX_DWORD StringToCode(const CFX_ByteStringC& str) const; can these be static ...
5 years, 1 month ago (2015-11-02 18:00:28 UTC) #4
dsinclair
https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_font/font_int.h File core/src/fpdfapi/fpdf_font/font_int.h (right): https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_font/font_int.h#newcode182 core/src/fpdfapi/fpdf_font/font_int.h:182: FX_DWORD StringToCode(const CFX_ByteStringC& str) const; On 2015/11/02 18:00:28, Tom ...
5 years, 1 month ago (2015-11-02 18:14:28 UTC) #5
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-02 18:27:04 UTC) #6
dsinclair
5 years, 1 month ago (2015-11-02 18:28:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
52b0b525dca3d982a04b77fa6d0913aff1e5fd9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698