Add test for StringToCode and StringToWideString.

Add test for StringToCode and StringToWideString

This CL adds a test case for the StringToCode and
StringToWideString methods in fpdf_font.cpp. In order
to do so, it moves the methods to be private methods of CPDF_ToUnicodeMap and
make the tests friends of the class.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/52b0b525dca3d982a04b77fa6d0913aff1e5fd9c

[dsinclair, 2015-11-02 17:54:20]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2015-11-02 17:54:21]

PTAL.

I believe I covered all the cases for these two methods. Please let me know if
you see any tests I missed.

[dsinclair, 2015-11-02 17:55:12]

Description was changed from

==========
Add test for CPDF_ToUnicodeMap::StringToCode.

This CL adds a test case for the StringToCode method in fpdf_font.cpp. In order
to do so, it moves the method to a private method of CPDF_ToUnicodeMap and
make the test a friend of the class.
==========

to

==========
Add test for StringToCode and StringToWideString

This CL adds a test case for the StringToCode and
StringToWideString methods in fpdf_font.cpp. In order
to do so, it moves the methods to be private methods of CPDF_ToUnicodeMap and
make the tests friends of the class.
==========

[Tom Sepez, 2015-11-02 18:00:28]

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/font_int.h (right):

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/font_int.h:182: FX_DWORD StringToCode(const
CFX_ByteStringC& str) const;
can these be static methods since they don't reference any members?

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp (right):

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp:29: res += 49835;
????

[dsinclair, 2015-11-02 18:14:28]

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/font_int.h (right):

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/font_int.h:182: FX_DWORD StringToCode(const
CFX_ByteStringC& str) const;
On 2015/11/02 18:00:28, Tom Sepez wrote:
> can these be static methods since they don't reference any members?

Done.

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp (right):

https://codereview.chromium.org/1428593005/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp:29: res += 49835;
On 2015/11/02 18:00:28, Tom Sepez wrote:
> ????

Done.

Converted to res += L"\xc2ab"; to be clearer what's happeninng/

[Tom Sepez, 2015-11-02 18:27:04]

lgtm

[dsinclair, 2015-11-02 18:28:03]

Committed patchset #3 (id:40001) manually as
52b0b525dca3d982a04b77fa6d0913aff1e5fd9c (presubmit successful).