Enable url_formatter::ElideUrl and url_formatter::ElideHost for aura Android

components/url_formatter/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
+import("//build/config/ui.gni")

[msw, 2015/11/03 23:55:33]

nit: add a blank line above.

[bshe, 2015/11/04 14:38:00]

Done.

 
 source_set("url_formatter") {
   sources = [
     "elide_url.cc",
     "elide_url.h",
     "url_fixer.cc",
     "url_fixer.h",
     "url_formatter.cc",
     "url_formatter.h",
   ]
 
   # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   deps = [
     "//base",
     "//third_party/icu",
     "//net",
+    "//ui/gfx",
     "//url",
   ]
 
-  if (!is_android) {
-    deps += [ "//ui/gfx" ]
+  if (is_android && !use_aura) {

[msw, 2015/11/03 23:55:33]

Consider: if (!is_android || use_aura) { deps += [ "//ui/gfx" ] }

[bshe, 2015/11/04 14:38:01]

Done.

+    deps -= [ "//ui/gfx" ]

[msw, 2015/11/03 23:55:33]

Shouldn't the GYP file have corresponding changes? url_formatter.gyp

[bshe, 2015/11/04 14:38:00]

For aura Android, we will only support gn build. The gyp version of aura Android
wont generate correct ninja file currently I believe. So I left gyp file
unchanged. My understanding is that gyp will eventually be replaced. So it is
probably fine to only change gn file?

[msw, 2015/11/04 19:16:11]

Hmm, it's a gray area, I's update GYP too, but it probably doesn't matter.

[bshe, 2015/11/04 22:38:21]

Right. Updated GYP file since it is pretty trivial to do so in this case. 

   }
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
     "elide_url_unittest.cc",
     "url_fixer_unittest.cc",
     "url_formatter_unittest.cc",
   ]
 
   deps = [
     ":url_formatter",
     "//base",
     "//net",
     "//testing/gtest",
     "//ui/gfx",
     "//url",
   ]
 
-  if (is_android) {
+  if (is_android && !use_aura) {
     deps -= [ "//ui/gfx" ]
   }
 }