Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 1428593002: Deprecate new internal Dartium/JsInterop APIs that are public (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/js/dartium/js_dartium.dart
diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart
index f2ab9c465602b7763ec5daa9a492aa34ac55be68..1c33511015886a3fa9fab283954ab9a9da0c5ead 100644
--- a/sdk/lib/js/dartium/js_dartium.dart
+++ b/sdk/lib/js/dartium/js_dartium.dart
@@ -207,7 +207,6 @@ class _DeclarationSet {
* Temporary method that we hope to remove at some point. This method should
* generally only be called by machine generated code.
*/
-
void registerJsInterfaces([List<Type> classes]) {
// This method is now obsolete in Dartium.
}
@@ -301,6 +300,7 @@ final _UNDEFINED_VAR = "_UNDEFINED_JS_CONST";
String _accessJsPath(String path) =>
"${_JS_LIBRARY_PREFIX}.context${path.split(".").map((p) => "['$p']").join('')}";
+@Deprecated("Internal Use Only")
void addMemberHelper(mirrors.MethodMirror declaration, String path, StringBuffer sb, {bool isStatic: false, String memberName}) {
var jsName = _getJsMemberName(declaration);
path = (path != null && path.isNotEmpty) ? "${path}.${jsName}" : jsName;
@@ -717,6 +717,7 @@ _maybeWrap(o) {
* we can access it from other libraries without it being
* a public instance field on JsObject.
*/
+@Deprecated("Internal Use Only")
getDartHtmlWrapperFor(JsObject object) => object._dartHtmlWrapper;
/**
@@ -724,6 +725,7 @@ getDartHtmlWrapperFor(JsObject object) => object._dartHtmlWrapper;
* we can access it from other libraries without it being
* a public instance field on JsObject.
*/
+@Deprecated("Internal Use Only")
void setDartHtmlWrapperFor(JsObject object, wrapper) {
object._dartHtmlWrapper = wrapper;
}
@@ -733,6 +735,7 @@ void setDartHtmlWrapperFor(JsObject object, wrapper) {
* argument is a Dart class instance that delegates to a DOM object. See
* wrap_jso defined in dart:html.
*/
+@Deprecated("Internal Use Only")
unwrap_jso(dartClass_instance) {
if (dartClass_instance is html.DartHtmlDomObject)
return dartClass_instance.blink_jsObject;
@@ -977,6 +980,7 @@ class JsObject extends NativeFieldWrapperClass2 {
// JavaScript interop methods that do not automatically wrap to dart:html types.
// Warning: this API is not exposed to dart:js.
+@Deprecated("Internal Use Only")
class JsNative {
static getProperty(JsObject o, name) {
return o._operator_getter(name);
@@ -1163,10 +1167,12 @@ Function _wrapAsDebuggerVarArgsFunction(JsFunction jsFunction) =>
// This method is a no-op in Dartium.
// TODO(jacobr): tag methods so we can throw if a Dart method is passed to
// JavaScript using the new interop without calling allowInterop.
+@Deprecated("Internal Use Only")
Function allowInterop(Function f) => f;
Expando<JsFunction> _interopCaptureThisExpando = new Expando<JsFunction>();
+@Deprecated("Internal Use Only")
Function allowInteropCaptureThis(Function f) {
if (f is JsFunction) {
// Behavior when the function is already a JS function is unspecified.
« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698