Issue 1428543004: [Android] Attempt to set device settings on eng builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1428543004: [Android] Attempt to set device settings on eng builds. (Closed)

Created:
5 years, 1 month ago by jbudorick

Modified:
5 years, 1 month ago

Reviewers:
rnephew (Reviews Here)

CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Attempt to set device settings on eng builds. BUG=546837 Committed: https://crrev.com/d87c735a634684f73afd39f54a2ab4c199a10b4c Cr-Commit-Position: refs/heads/master@{#356942}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	build/android/pylib/device_settings.py	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rnephew (Reviews Here)

On 2015/10/29 19:38:25, jbudorick wrote: lgtm

5 years, 1 month ago (2015-10-29 19:53:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428543004/1

5 years, 1 month ago (2015-10-29 19:55:56 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-10-29 21:03:00 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d87c735a634684f73afd39f54a2ab4c199a10b4c
Cr-Commit-Position: refs/heads/master@{#356942}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages