Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1428533003: Fix crash in device_sensors. (Closed)

Created:
5 years, 1 month ago by Alexander Semashko
Modified:
5 years, 1 month ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in device_sensors. If a consumer type is not supported, it is not added to consumers_bitmask_ in AddConsumer. But in RemoveConsumer it is xored into the mask, because fetcher_->Stop normally returns true for valid consumer types; then this mask is passed into fetcher_->Fetch, and e.g. on mac the fetcher crashes. BUG= Committed: https://crrev.com/9d8539f53682e5a08a3dfa9524f399aa2406a528 Cr-Commit-Position: refs/heads/master@{#357103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Alexander Semashko
5 years, 1 month ago (2015-10-27 15:14:36 UTC) #2
Alexander Semashko
hans, can you take a look please?
5 years, 1 month ago (2015-10-30 10:22:45 UTC) #5
timvolodine
On 2015/10/30 10:22:45, ahest wrote: > hans, can you take a look please? hans and ...
5 years, 1 month ago (2015-10-30 13:27:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428533003/1
5 years, 1 month ago (2015-10-30 13:41:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 14:48:45 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:49:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d8539f53682e5a08a3dfa9524f399aa2406a528
Cr-Commit-Position: refs/heads/master@{#357103}

Powered by Google App Engine
This is Rietveld 408576698