Chromium Code Reviews| Index: chrome/browser/resources/settings/site_settings/site_list.js |
| diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js |
| index 613008a45b174e9debbf7b4933dd693a7e82014e..55f64b73463792c6fcc4563e3a7fd0f869811424 100644 |
| --- a/chrome/browser/resources/settings/site_settings/site_list.js |
| +++ b/chrome/browser/resources/settings/site_settings/site_list.js |
| @@ -143,7 +143,8 @@ Polymer({ |
| this.computeCategoryExceptionsPrefName(this.category)); |
| var sites = pref.value; |
| for (var origin in sites) { |
| - if (sites[origin].setting == this.categorySubtype) { |
| + var site = /** @type {{setting: number}} */(sites[origin]); |
| + if (site.setting == this.categorySubtype) { |
| var tokens = origin.split(','); |
| newList.push({url: tokens[0]}); |
| } |
| @@ -166,6 +167,7 @@ Polymer({ |
| /** |
| * A handler for selecting a site (by clicking on the origin). |
| + * @param {!{model: !{item: !{url: string}}}} event |
|
Dan Beam
2015/11/11 23:18:39
this should probably be {Event}
|
| * @private |
| */ |
| onOriginTap_: function(event) { |
|
Dan Beam
2015/11/11 23:18:39
and this should probably be
var model = /** @type
michaelpg
2015/11/20 14:26:55
I think you mean (event['model']). if you @param e
|
| @@ -182,7 +184,7 @@ Polymer({ |
| /** |
| * Returns the appropriate header value for display. |
| - * @param {array<string>} siteList The list of all sites to display for this |
| + * @param {Array<string>} siteList The list of all sites to display for this |
| * category subtype. |
| * @param {boolean} toggleState The state of the global toggle for this |
| * category. |
| @@ -213,7 +215,7 @@ Polymer({ |
| /** |
| * Returns whether to show the site list. |
| - * @param {array} siteList The list of all sites to display for this category |
| + * @param {Array} siteList The list of all sites to display for this category |
| * subtype. |
| * @param {boolean} toggleState The state of the global toggle for this |
| * category. |