Add Closure compiling instructions for site_list.

chrome/browser/resources/settings/site_settings/site_list.js

Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index 613008a45b174e9debbf7b4933dd693a7e82014e..42eb72ac06092b5dafa7e9ebd27c6aac4fe30b0d 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -143,7 +143,8 @@ Polymer({
         this.computeCategoryExceptionsPrefName(this.category));
     var sites = pref.value;
     for (var origin in sites) {
-      if (sites[origin].setting == this.categorySubtype) {
+      var setting = /** @type {{setting: number}} */((sites[origin]).setting);

[Dan Beam, 2015/11/11 07:01:39]

this is also casting incorrectly because you're saying

(sites[origin].setting) -> yields an object with a 'setting' key that has a
value of type number

this should probably be:

  var setting = /** @type {{setting: number}} */(origins[sites]);
  if (setting.setting == this.categorySubtype) {

+      if (setting == this.categorySubtype) {
         var tokens = origin.split(',');
         newList.push({url: tokens[0]});
       }
@@ -169,6 +170,7 @@ Polymer({
    * @private
    */
   onOriginTap_: function(event) {
+    /** @type {{model:Object}}*/

[Dan Beam, 2015/11/11 07:01:39]

the current code means "this.selectedOrigin is an object with a key of 'model'
that has a value of Object or null".  basically: it's all wrong.

/** @param {Event} event */
onOriginTap_: function(event) {
  e = /** @type {{model: Object}} */(e);
  ...
},

is closer to right, but it doesn't actually describe the rest of the path
(.item.url).  is there a @typedef or how is this information generated?

     this.selectedOrigin = event.model.item.url;
   },
 
@@ -182,7 +184,7 @@ Polymer({
 
   /**
    * Returns the appropriate header value for display.
-   * @param {array<string>} siteList The list of all sites to display for this
+   * @param {Array<string>} siteList The list of all sites to display for this
    *     category subtype.
    * @param {boolean} toggleState The state of the global toggle for this
    *     category.
@@ -213,7 +215,7 @@ Polymer({
 
   /**
    * Returns whether to show the site list.
-   * @param {array} siteList The list of all sites to display for this category
+   * @param {Array} siteList The list of all sites to display for this category
    *     subtype.
    * @param {boolean} toggleState The state of the global toggle for this
    *     category.