Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 1428523006: Add Closure compiling instructions for site_list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to approved version Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/compiled_resources.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index 5f0f4a7e098349b8e9a396775fbd78647551e75e..d7d4c33985f37c5913c1b7416d19047d91b75794 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -143,7 +143,8 @@ Polymer({
this.computeCategoryExceptionsPrefName(this.category));
var sites = pref.value;
for (var origin in sites) {
- if (sites[origin].setting == this.categorySubtype) {
+ var site = /** @type {{setting: number}} */(sites[origin]);
+ if (site.setting == this.categorySubtype) {
var tokens = origin.split(',');
newList.push({url: tokens[0]});
}
@@ -166,6 +167,7 @@ Polymer({
/**
* A handler for selecting a site (by clicking on the origin).
+ * @param {!{model: !{item: !{url: string}}}} event
* @private
*/
onOriginTap_: function(event) {
@@ -182,7 +184,7 @@ Polymer({
/**
* Returns the appropriate header value for display.
- * @param {array<string>} siteList The list of all sites to display for this
+ * @param {Array<string>} siteList The list of all sites to display for this
* category subtype.
* @param {boolean} toggleState The state of the global toggle for this
* category.
@@ -213,7 +215,7 @@ Polymer({
/**
* Returns whether to show the site list.
- * @param {array} siteList The list of all sites to display for this category
+ * @param {Array} siteList The list of all sites to display for this category
* subtype.
* @param {boolean} toggleState The state of the global toggle for this
* category.
« no previous file with comments | « chrome/browser/resources/settings/site_settings/compiled_resources.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698