Add Closure compiling instructions for site_list.

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-site-list' shows a list of Allowed and Blocked sites for a given
  * category.
  *
  * Example:
@@ skipping 125 matching lines @@
   /**
    * Populate the sites list for display.
    * @private
    */
   populateList_: function() {
     var newList = [];
     var pref = this.getPref(
         this.computeCategoryExceptionsPrefName(this.category));
     var sites = pref.value;
     for (var origin in sites) {
-      if (sites[origin].setting == this.categorySubtype) {
+      var setting = /** @type {{setting: number}} */((sites[origin]).setting);

[Dan Beam, 2015/11/11 07:01:39]

this is also casting incorrectly because you're saying

(sites[origin].setting) -> yields an object with a 'setting' key that has a
value of type number

this should probably be:

  var setting = /** @type {{setting: number}} */(origins[sites]);
  if (setting.setting == this.categorySubtype) {

+      if (setting == this.categorySubtype) {
         var tokens = origin.split(',');
         newList.push({url: tokens[0]});
       }
     }
 
     this.sites_ = newList;
   },
 
   /**
    * Setup the values to use for the action menu.
    * @private
    */
   setUpActionMenu_: function() {
     this.showAllowAction_ =
         this.categorySubtype == settings.DefaultValues.BLOCK;
     this.showBlockAction_ =
         this.categorySubtype == settings.DefaultValues.ALLOW &&
         this.category != settings.ContentSettingsTypes.FULLSCREEN;
   },
 
   /**
    * A handler for selecting a site (by clicking on the origin).
    * @private
    */
   onOriginTap_: function(event) {
+    /** @type {{model:Object}}*/

[Dan Beam, 2015/11/11 07:01:39]

the current code means "this.selectedOrigin is an object with a key of 'model'
that has a value of Object or null".  basically: it's all wrong.

/** @param {Event} event */
onOriginTap_: function(event) {
  e = /** @type {{model: Object}} */(e);
  ...
},

is closer to right, but it doesn't actually describe the rest of the path
(.item.url).  is there a @typedef or how is this information generated?

     this.selectedOrigin = event.model.item.url;
   },
 
   /**
    * A handler for activating one of the menu action items.
    * @private
    */
   onActionMenuIronSelect_: function(event) {
     // TODO(finnur): Implement.
   },
 
   /**
    * Returns the appropriate header value for display.
-   * @param {array<string>} siteList The list of all sites to display for this
+   * @param {Array<string>} siteList The list of all sites to display for this
    *     category subtype.
    * @param {boolean} toggleState The state of the global toggle for this
    *     category.
    * @private
    */
   computeSiteListHeader_: function(siteList, toggleState) {
     if (this.categorySubtype == settings.DefaultValues.ALLOW) {
       return loadTimeData.getStringF(
           'titleAndCount',
           loadTimeData.getString(
@@ skipping 10 matching lines @@
   /**
    * Returns true if this widget is showing the allow list.
    * @private
    */
   isAllowList_: function() {
     return this.categorySubtype == settings.DefaultValues.ALLOW;
   },
 
   /**
    * Returns whether to show the site list.
-   * @param {array} siteList The list of all sites to display for this category
+   * @param {Array} siteList The list of all sites to display for this category
    *     subtype.
    * @param {boolean} toggleState The state of the global toggle for this
    *     category.
    * @private
    */
   showSiteList_: function(siteList, toggleState) {
     if (siteList.length == 0)
       return false;
     // The Block list is only shown when the category is set to Allow since it
     // is redundant to also list all the sites that are blocked.
     if (this.isAllowList_())
       return true;
 
     return toggleState;
   },
 
   /**
    * Returns the icon to use for a given site.
    * @param {string} url The url of the site to fetch the icon for.
    * @private
    */
   computeSiteIcon_: function(url) {
     // TODO(finnur): For now, we're returning a placeholder image for each site
     // but the actual favicon for each site will need to be returned.
     return 'communication:message';
   },
 });