Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1428453002: Eliminate unhelpful ERROR logging in accellerometer_reader.cc on linux (Closed)

Created:
5 years, 1 month ago by stevenjb
Modified:
5 years, 1 month ago
Reviewers:
flackr, jonross
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate unhelpful ERROR logging in accellerometer_reader.cc on linux Running chrome built with chromeos=1 produces unhelpful ERROR messages since the expected directories do not exist. BUG=547836 Committed: https://crrev.com/47375bd08398676f5fb652077d69d543f6e8b556 Cr-Commit-Position: refs/heads/master@{#357390}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chromeos/accelerometer/accelerometer_reader.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
stevenjb
5 years, 1 month ago (2015-10-26 17:32:39 UTC) #2
stevenjb
+flackr@
5 years, 1 month ago (2015-10-28 18:50:12 UTC) #4
jonross
On 2015/10/28 18:50:12, stevenjb wrote: > +flackr@ LGTM
5 years, 1 month ago (2015-10-30 13:43:11 UTC) #5
flackr
lgtm
5 years, 1 month ago (2015-10-30 14:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428453002/20001
5 years, 1 month ago (2015-11-02 18:08:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 18:39:21 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 18:40:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47375bd08398676f5fb652077d69d543f6e8b556
Cr-Commit-Position: refs/heads/master@{#357390}

Powered by Google App Engine
This is Rietveld 408576698