src/stub-cache.cc - Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/stub-cache.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Split apart ForOffset into ForJSObjectOffset, ForJSArrayOffset, and ForFixedArrayOffset Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/stub-cache.cc

diff --git a/src/stub-cache.cc b/src/stub-cache.cc

index 214527f09c17fced40202ed429c144b6e04be03e..e6f71e0138ab1d9a3d2f586c173512c408e3abfc 100644

--- a/src/stub-cache.cc

+++ b/src/stub-cache.cc

@@ -338,6 +338,7 @@ Handle<Code> StubCache::ComputeKeyedLoadField(Handle<Name> name,

Handle<JSObject> holder,

PropertyIndex field) {

if (receiver.is_identical_to(holder)) {

+ // TODO(titzer): this should use an HObjectAccess

KeyedLoadFieldStub stub(field.is_inobject(holder),

field.translate(holder));

return stub.GetCode(isolate());

« src/hydrogen-instructions.cc ('K') | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »