Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

src/hydrogen.h

Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index ab721bd3af19e02e7d45eb44bdb822cea7d118e9..c76863c0bc63a909489ccf3f09c85f397fb1962c 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1022,8 +1022,20 @@ class HGraphBuilder {
       KeyedAccessStoreMode store_mode,
       Representation checked_index_representation = Representation::None());
 
-  HInstruction* BuildStoreMap(HValue* object, HValue* map);
-  HInstruction* BuildStoreMap(HValue* object, Handle<Map> map);
+  HLoadNamedField * AddLoad(HValue *object, HObjectAccess* access,
+      HValue *typecheck = NULL);
+  HStoreNamedField* AddStore(HValue *object, HObjectAccess* access,
+      HValue *val, Representation representation = Representation::Tagged());
+  HStoreNamedField* AddStoreMapConstant(HValue *object, Handle<Map>);
+
+  HObjectAccess* AccessArrayHeader(int offset);
+  HObjectAccess* AccessArrayLength();
+  HObjectAccess* AccessElements();
+  HObjectAccess* AccessFixedArrayLength();
+  HObjectAccess* AccessMap();
+  HObjectAccess* AccessField(Handle<Map> map, Handle<String> name,
+     LookupResult* lookup);
+  HObjectAccess* AccessInobject(Handle<String> name, int offset);

[danno, 2013/05/02 14:16:47]

Why not have this as a constructor for HObjectAccess so it can be allocated on
the stack? Prevents having to allocate lots of temporary objects that don't have
to live very long anyway. 

[titzer, 2013/05/03 09:18:41]

Because the HObjectAccess pointers are actually being stored in the load/store
instructions and thus live longer than the graph builder's stack.

 
   class IfBuilder {
    public: