Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use BitField utility instead of C-language bitfield for portion and offset in HObjectAccess. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 if (is_double) { 409 if (is_double) {
410 return LDoubleStackSlot::Create(index, zone()); 410 return LDoubleStackSlot::Create(index, zone());
411 } else { 411 } else {
412 return LStackSlot::Create(index, zone()); 412 return LStackSlot::Create(index, zone());
413 } 413 }
414 } 414 }
415 415
416 416
417 void LStoreNamedField::PrintDataTo(StringStream* stream) { 417 void LStoreNamedField::PrintDataTo(StringStream* stream) {
418 object()->PrintTo(stream); 418 object()->PrintTo(stream);
419 stream->Add("."); 419 hydrogen()->access().PrintTo(stream);
420 stream->Add(*String::cast(*name())->ToCString());
421 stream->Add(" <- "); 420 stream->Add(" <- ");
422 value()->PrintTo(stream); 421 value()->PrintTo(stream);
423 } 422 }
424 423
425 424
426 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) { 425 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
427 object()->PrintTo(stream); 426 object()->PrintTo(stream);
428 stream->Add("."); 427 stream->Add(".");
429 stream->Add(*String::cast(*name())->ToCString()); 428 stream->Add(*String::cast(*name())->ToCString());
430 stream->Add(" <- "); 429 stream->Add(" <- ");
(...skipping 2322 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2752 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2754 LOperand* object = UseRegister(instr->object()); 2753 LOperand* object = UseRegister(instr->object());
2755 LOperand* index = UseTempRegister(instr->index()); 2754 LOperand* index = UseTempRegister(instr->index());
2756 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2755 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2757 } 2756 }
2758 2757
2759 2758
2760 } } // namespace v8::internal 2759 } } // namespace v8::internal
2761 2760
2762 #endif // V8_TARGET_ARCH_IA32 2761 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698