Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Split apart ForOffset into ForJSObjectOffset, ForJSArrayOffset, and ForFixedArrayOffset Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 if (is_double) { 418 if (is_double) {
419 return LDoubleStackSlot::Create(index, zone()); 419 return LDoubleStackSlot::Create(index, zone());
420 } else { 420 } else {
421 return LStackSlot::Create(index, zone()); 421 return LStackSlot::Create(index, zone());
422 } 422 }
423 } 423 }
424 424
425 425
426 void LStoreNamedField::PrintDataTo(StringStream* stream) { 426 void LStoreNamedField::PrintDataTo(StringStream* stream) {
427 object()->PrintTo(stream); 427 object()->PrintTo(stream);
428 stream->Add("."); 428 stream->Add(".@%d", offset()); // TODO(titzer): use HObjectAccess
429 stream->Add(*String::cast(*name())->ToCString());
430 stream->Add(" <- "); 429 stream->Add(" <- ");
431 value()->PrintTo(stream); 430 value()->PrintTo(stream);
432 } 431 }
433 432
434 433
435 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) { 434 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
436 object()->PrintTo(stream); 435 object()->PrintTo(stream);
437 stream->Add("."); 436 stream->Add(".");
438 stream->Add(*String::cast(*name())->ToCString()); 437 stream->Add(*String::cast(*name())->ToCString());
439 stream->Add(" <- "); 438 stream->Add(" <- ");
(...skipping 2325 matching lines...) Expand 10 before | Expand all | Expand 10 after
2765 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2764 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2766 LOperand* object = UseRegister(instr->object()); 2765 LOperand* object = UseRegister(instr->object());
2767 LOperand* index = UseTempRegister(instr->index()); 2766 LOperand* index = UseTempRegister(instr->index());
2768 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2767 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2769 } 2768 }
2770 2769
2771 2770
2772 } } // namespace v8::internal 2771 } } // namespace v8::internal
2773 2772
2774 #endif // V8_TARGET_ARCH_IA32 2773 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698